Activity Since 2022.09.1 Release — Activity since 2022-09-30

• PullRequests

  Earliest to Most-Recent

  • Add discord channel #811 [djchou]

    from Ted Patrick -- tedpatrick — 09/19/2022 Hello and Good Morning (CST in Austin TX) Key: We want the dialog about...

    Show Children

    • madhur-tandon

  • update docs for the minimal config #807 [madhur-tandon] tag: docs sprint

    @tedpatrick please merge this before the release :)

  • TOML Error Cases #815 [tedpatrick]

    Swap fast-toml for toml-j to address failing errors with invalid TOML. Closes #812

    Show Children

    • madhur-tandon

    • madhur-tandon: I have checked locally as well -- we do get an error on the browser too, and the integration...

  • use structured TOML parser #813 [madhur-tandon]

    cc: @tedpatrick This should be enough to play around with why it hangs. Note that the throwing of error occurs at...

    Show Children

    • madhur-tandon: The test...

    • tedpatrick: Added identical tests to other PR with a different toml lib. Plan B.

  • Add tsc as an optional build step with --noEmit #816 [tedpatrick]

    This allows us to run the TypeScript compiler directly. Rollup runs this same command within rollup -c but we are...

    Show Children

    • ntoll

  • Refactor py-config and the general initialization logic of the page #806 [antocuni]

    This PR is the first step to improve and rationalize the life-cycle of a pyscript app along the lines of what I...

    Show Children

    • madhur-tandon: @antocuni these were deliberately misspelled, since it is the covfefe language aka it is...

      • antocuni: it's not a big deal, but typos are subtle: I can imagine that in the future someone might write...

    • antocuni: I don't really understand why pre-commit checks are failing on CI. They pass on my machine, even...

    • FabioRosado: This is cool! I added a comment about the customElements, let me know if you need context on...

      • FabioRosado: Just wanted top confirm, this will make sure that pyodide is loaded before we start creating the...

        • antocuni: not really: in this PR I intentionally tried to preserve the existing logic as much as possible,...

        • FabioRosado: That makes sense thank you @antocuni !

      • FabioRosado: This is likely a bad idea (and you probably thought about it already). Since...

        • antocuni: yes, probably the comment is poorly worded. What I wanted to say is "I know it's an issue but I...

        • ntoll: For simplicity, my feeling is we should do something obvious like enforce only a single...

        • antocuni: For simplicity, my feeling is we should do something obvious like enforce only a single and...

        • ntoll: I'd say do it now. Strike while the iron's hot.

      • FabioRosado: This is mostly a question for my understanding. Is it possible that runtimeSpec be undefined...

        • antocuni: same answer as above: the messy logic didn't really change here, so it might be possible. But I...

        • FabioRosado: That makes sense I missed that context thank you!

      • FabioRosado: I hope you don't mind this comment, should this have some spacing? ...

        • antocuni: I don't mind at all! I'm 💯 for good code formatting, thanks for noticing! :)

        • ntoll: Do we not have a linter or something that reformats..? A TS version of black..?

    • JeffersGlass: I don't really understand why pre-commit checks are failing on CI. They pass on my machine, even...

    • ntoll: We'll need to figure out the multiple-interpreters story for this... e.g. defining what...

      • antocuni: I agree. Personally, I would like to change the config to allow only one runtime instead of...

      • ntoll: KISS (keep it simple, stupid)... totally agree. Also, if you need more than one runtime, you're...

    • antocuni: I don't really understand why pre-commit checks are failing on CI. They pass on my machine, even...

    • antocuni: I tried to revert eslint to the previous version in 0dca198, let's see what happens still failing

    • ntoll: Weird that CI / eslint is failing. We can fix that in another change. But glad to see this...

    • tedpatrick: If you run tsc (TypeScript compiler) directly, you get identical errors as eslint. add...

    • tedpatrick

  • Add a link to docs in the README #817 [antocuni]

    Show Children

    • madhur-tandon

  • Add Github Stale to PyScript repo #791 [tedpatrick]

    This adds "Github Stale" support to pyscript/pyscript repo with a base configuration within this PR. A staler...

  • eliminate py-env altogether #775 [madhur-tandon] sprint

    closes #343

    Show Children

    • tedpatrick

  • Update to Codemirror 6 (py-repl) #814 [JeffersGlass]

    Upgrades CodeMirror to Version 6, released early June, which seems like it'll be API stable for the foreseeable...

    Show Children

    • madhur-tandon: Thanks @JeffersGlass Just for the future -- since CodeMirror is a heavy dependency, we might...

    • tedpatrick: Awesome, I added this to the release planning list this morning... "Upgrade to codemirror 6.0.1...

    • tedpatrick

    • tedpatrick: @JeffersGlass Yours to merge. Rule: You build it, you merge it.

    • marimeireles: Yesss! Thank you for this! Months ago I was trying to deal with the old version of codemirror to...

    • madhur-tandon: Conflicts need to be resolved I guess, then we are good to go!

    • JeffersGlass: Good thinking on dynamic loading @madhur-tandon - we might want to do an audit on the packages...

  • Add epic to exempt labels #821 [tedpatrick]

    Show Children

    • marimeireles: Yep!

    • marimeireles

  • Link in README Resources for Stack Overflow tag #507 [nmstoker]

    As per pyscript/pyscript-collective#30 proposing this simple one liner change to the README

    Show Children

    • nmstoker: Sure. Am away for a few days but I'll sort the PR for the other repo next week 🙂

  • Maintainers Update #823 [tedpatrick]

  • Update CONTRIBUTING.md #822 [marimeireles]

    To add that we need to have a test for every feature :) closes #615 and it's the final issue on the list which will...

    Show Children

    • tedpatrick

  • Detect multiple <py-config> #826 [antocuni]

    Detect the case in which multiple are listed. Ideally I would like it to be a fatal error, but it's too hard to do...

    Show Children

    • JeffersGlass: LGTM - agreed about moving the styling of the error to CSS at some point down the road.

  • [WIP] Makefile and examples cleanup/simplification #696 [pww217]

    Sister PR of #695, separated to keep readable This PR shifts Makefile and example usage towards local builds and...

    Show Children

    • tedpatrick: Closing given make examples and testing work

  • adding the DNA example #600 [meg-1] status: paused tag: example

    Given one side of a DNA strand, this example returns the other, complementary side of said strand.

    Show Children

    • tedpatrick: Closing given examples are headed to PyScript Collective and now duplicate PRs.

  • adding the interest_calculator example #590 [meg-1] status: paused tag: example

    Adding the "Compound and Simple Interest Calculator" as a PyScript example.

    Show Children

    • tedpatrick: Contributed examples should be submitted as PRs to...

  • mario enhancements #742 [meg-1] status: paused

    adding a few enhancements to the Mario example for better UI and usage. fixing a bug where a snippet of code...

    Show Children

    • tedpatrick: Contributed examples should be submitted as PRs to...

  • Create counter.html #500 [anzarwani] status: paused tag: example

    Counter app

    Show Children

    • tedpatrick: Contributed examples should be submitted as PRs to...

  • Fix/examples mariogame #474 [tawfiqkhalilieh] waiting on reporter status: paused tag: example

    Fixed some bugs in Mario game like showing the pyscript code and the 404 status code while calling the defer and...

    Show Children

    • tedpatrick: Contributed examples should be submitted as PRs to...

  • Add PyMC demo. #398 [twiecki] status: paused tag: example

    Description: https://www.pymc-labs.io/blog-posts/pymc-in-browser/ Demo: https://twiecki.io/pymc-in-browser.html

    Show Children

    • tedpatrick: Contributed examples should be submitted as PRs to...

  • feat: add new example of a calculator app with html and css ui/ux #278 [KOSIDOCS] status: paused tag: example

    #Description No example at the moment was implemented using a good UI/UX with HTML and CSS. #Solution I created a...

    Show Children

    • tedpatrick: Contributed examples should be submitted as PRs to...

  • add basic HTTP requests async demo with pyfetch #151 [emirkmo] status: paused tag: example sprint

    Summary Add a basic asynchronus demo in pure python for using pyodide.http.pyfetch for making HTTP...

    Show Children

    • tedpatrick: Contributed examples should be submitted as PRs to...

  • Adding Counter App example #113 [castasint] status: paused tag: example

    This is a basic counter app. This will show how to execute Python code to keep track of the Counter variable.

    Show Children

    • tedpatrick: Contributed examples should be submitted as PRs to...

  • [Rajat] added example for fetch api (using bpi price api) #141 [Rjtsahu] status: paused tag: example

    This is an example to show how to use REST API client ( as requests will not work) Used an open free API to show the...

    Show Children

    • tedpatrick: Contributed examples should be submitted as PRs to...

  • Added pyscript and django-rest example #567 [steelthedev] status: paused tag: example

    Created A simple to-do app with pyscript and Django rest framework. A good example that shows the use of pyfetch and...

    Show Children

    • tedpatrick: Contributed examples should be submitted as PRs to...

    • steelthedev: @tedpatrick done that for a while now.

    • pauleveritt: @steelthedev That's on me then. I've still a WIP on the examples infrastructure. I'm open to any...

    • tedpatrick: Starting is hard and we are just now ironing out the process and direction. We had a long delay...

  • SVG Docs logo #832 [tedpatrick]

    Replace static pyscript logo with svg. Looks great in dark or light mode Tiny Mobile friendly Fixes #818

    Show Children

    • tedpatrick

    • JeffersGlass: LGTM!

  • Remove fortawesome/free-solid-svg-icons #831 [JeffersGlass]

    Removes @fortawesome/free-solid-svg-icons from the dependencies - as far as I can tell, it isn't used anywhere. From...

    Show Children

    • madhur-tandon

  • Make the life-cycle more linear and kill some svelte stores #830 [antocuni]

    This is a follow-up of PR #806 and it's a big step forward towards solving issue #763. The basic idea is that at...

    Show Children

    • tedpatrick: ✅ https://caniuse.com/mdn-api_console_assert 97%

      • antocuni: yes, basically my question was whether this is the idiomatic way to do it or there are better...

      • tedpatrick: ES2+ asserts :) if( this.config !== undefined ){ throw new Error('Fatal: no config')} if(...

    • tedpatrick: parallel loading await Promise.all([ runtime.installPackage(this.config.packages), ...

      • antocuni: thanks! This looks like a very useful idiom, I'll keep it in mind. But I don't want to fix it in...

    • tedpatrick: parallel: await Promise.all( paths.map( runtime.loadFromFile ) ) .catch( handleFetchError...

      • antocuni: same comment as above

    • tedpatrick

    • marimeireles: This looks great! So much more organized and easier to understand. Great work @antocuni :)

      • marimeireles: I wonder if it's worth it to change these names? I think these they are so confusing... Do you...

        • antocuni: they are going to be killed soon ☠️

      • marimeireles: Grateful for docs in the code 🙏

      • marimeireles: Is this just the way you do lambdas in TS? (Asking because I'm TS noob)

        • antocuni: yes, it's not even TS-specific, it works the same in plain JS. They are not called lambda...

  • Add cache, fetch, retry logic to tests #829 [tedpatrick]

    Let's make the tests run faster. Cache network assets as used in an in-memory cache Reuse cache to avoid network...

    Show Children

    • tedpatrick: Notes: The tests run about 1.5m faster The network calls are 2x resilent so tests will be less...

    • tedpatrick: ESLint... tomorrow! :)

    • antocuni: I don't know what's happening, but now --headed no longer works. If you try to run any test with...

    • antocuni: small nitpicks here, but the problem with --headed is a merge blocker IMHO (I use it a lot)

      • antocuni: this is dangerous, I'd prefer to catch only the specific kind of exception that we expect

        • tedpatrick: Discovering the Exception types that page.request.fetch generates. Will narrow this down tight.

        • tedpatrick: Added PlaywrightRequestError to isolate Support for --headed

      • antocuni: I don't really understand what this comment means :)

        • tedpatrick: # cache storing request objects by a key computed as the sha256 of the url

        • tedpatrick: I am planning to also limit this to GET requests.

    • madhur-tandon: In my opinion, the snippets under try and catch are exactly the same, so it makes sense to make...

      • tedpatrick: These are at very different levels: One means the entire test reruns One means we retry a web...

      • madhur-tandon: What I mean is that -- a decorator would give us the opportunity to: control the number of...

      • tedpatrick: Decorator for simplifying logic. Thanks @madhur-tandon

      • madhur-tandon: resolving...

    • tedpatrick: Status: Removed http server Added --parallel auto Results: Local - Full integration suite runs...

    • madhur-tandon: @tedpatrick IMO, we shouldn't remove this test. The reason is that we want to check if passing a...

      • madhur-tandon: cc: @antocuni

      • tedpatrick: @madhur-tandon I need your help finding the zip contents so I can intercept them locally. This...

      • madhur-tandon: The tar file (zipped) is stored in a path denoted by the tar_location fixture. But the contents...

      • tedpatrick: Fixed

      • tedpatrick: this has been restored

    • madhur-tandon: can replace http://localhost:8080/ with f"{self.http_server}/"

      • tedpatrick: fixed

    • madhur-tandon: can replace http://localhost:8080/pyodide/ with f"{self.http_server}/pyodide/"

      • tedpatrick: fixed

    • madhur-tandon: I think this target i.e. test-one can be removed since it's not used anywhere.

      • madhur-tandon: Once you are done with all the local testing of course.

      • tedpatrick: fixed

    • antocuni: With the removal of the HTTP server, the pytest --headed needs an http server running over...

    • antocuni: ah, I see that you just readded --headed support, thank you 🎉

    • tedpatrick: @antocuni I will set --parallel to run in GHActions and optionally locally. I keep seeing we...

    • tedpatrick: I believe this is ready for a deeper review.

    • antocuni: @tedpatrick as discussed privately, I refactored a bit the code. The biggest issue was that the...

    • tedpatrick: Ran all tests locally 💯 Simpler ✅ Cache actually works 🥇 I love it. 🚢 it.

    • antocuni

    • tedpatrick: 🚢 it!

  • Add directly listing for releases #838 [tedpatrick]

    Add an HTML file to the build folder. This will provide a directory listing here contains a pyscript app using the...

    Show Children

    • madhur-tandon

  • Fix the director listing example. #841 [tedpatrick]

    Correct the url in the example

    Show Children

    • madhur-tandon

  • Add directly listing for releases (fix error) #839 [tedpatrick]

    The rollup configuration was not set to allow copy during production build. copy index.html to build directory ever build

    Show Children

    • madhur-tandon

    • tedpatrick: Fixed: https://pyscript.net/unstable/

    • JeffersGlass: Something in this has broken the dev builds (base) PS D:\pyscript\pyscriptjs> npm run dev >...

  • slight improvement on the Local Modules subsection #92 [sukruozan] status: declined tag: docs

    a proposal for a slight improvement on the Local Modules subsection

    Show Children

    • sukruozan: Dear Philipp, Thanks for your quick response. I totally understand your hesitation. Mine was...

  • Upgrade and pin dependencies #840 [tedpatrick]

    Pin all dependency versions Upgrade all dependencies Remove unused dependencies via...

    Show Children

    • madhur-tandon: seems like stores aren't used anymore? Did @antocuni eliminate them all?

      • tedpatrick: svelte is a compiler and is normally set as a dev dependency. stores are from import { writable...

      • madhur-tandon: thanks, resolving...

    • JeffersGlass: Now that font-awesome is gone, and svelte-fa is going, can probably remove the references to...

    • tedpatrick: removed the svelte-fa css. Also tested Play button SVG, looks great.

    • madhur-tandon

  • Don't hide undefined elements in the CSS #837 [tedpatrick]

    Hide <py-config> element using display:none Stop hiding undefined elements, this is a risk to hide other web...

    Show Children

    • marimeireles: This is great! I feel like we should add a test for it?

    • marimeireles: I can do it, if you prefer ;)

    • antocuni: I think that the problem with this approach is that the python source code inside <py-script>...

    • tedpatrick: If there is CSS for an element as display:none, this will hide the element before pyscript is...

    • tedpatrick: Ah this is web component selector behavior in CSS. simple-custom:not(:defined) { display: none; }

    • tedpatrick: Add these /* py-config - not a component */ py-config { display: none } /* py-{el} -...

    • tedpatrick: Added test for testing dom visibility with no pyscript Added test for testing dom visibility...

    • tedpatrick: This is ready to go. Define CSS for each element, nothing generic Add test for not defined. Do...

    • antocuni: LGTM

      • antocuni: neat! :)

    • madhur-tandon

    • marimeireles: I wonder if we should have simpler examples for these? Not a blocker, just wondering. +1 to merge =)

      • tedpatrick: I feel it covers the 2 cases... before definition and after definition. Goal was to test all...

    • marimeireles

  • Use only single rollup-plugin-copy() to avoid race condition #843 [JeffersGlass]

    #839 improved rollup logic - it always copies build folder to examples/build, regardless of whether this is a...

    Show Children

    • tedpatrick: If we are managing file copy_targets, let's remove the !production on line 63 limiting this to...

      • JeffersGlass: Agreed and removed.

    • tedpatrick: These should be deleted as they are duplicate and the directory listing does not need to be...

      • JeffersGlass: Agreed and removed.

    • tedpatrick: I think we need to revisit this one. Definition of production is polluted by...

    • tedpatrick: Something like: https://gist.github.com/tedpatrick/d0ab5155e2738d2b7c61d013b11a4f0e

    • JeffersGlass: Thanks @tedpatrick ! I've adjusted the file per your thoughts, removing the duplicate commands...

    • tedpatrick: It looks like the serve command is called in GitHub Actions during the build and it stops and listens

    • tedpatrick: I think it is this line defining production const production = !process.env.ROLLUP_WATCH ||...

    • JeffersGlass: I think it is this line defining production const production = !process.env.ROLLUP_WATCH ||...

    • tedpatrick: Rerunning actions. It looked to fail in an integration test. But the fact that it reaches...

    • tedpatrick: Yes I agree, the !process.env.ROLLUP_WATCH is confusing

    • tedpatrick

    • tedpatrick: @JeffersGlass Merge when ready. Merge policy: You build it, you merge it!

    • tedpatrick: Great work @JeffersGlass, Thanks.

  • Remove an unused import #858 [woxtu]

    Hi, This PR removes an unused import to resolve the following pre-commit error: $ pre-commit run flake8...

    Show Children

    • madhur-tandon

  • kill stores.runtimeLoaded and many other stores #850 [antocuni]

    As the title stays, the main goal of the branch is to kill the infamous runtimeLoaded global store and all the...

    Show Children

    • madhur-tandon: LGTM, the suggestion for hide whitespace helped, thanks for that -- learnt something new.

    • madhur-tandon: minor typo though: don't to anything --> don't do anything

      • antocuni: thanks, fixed by bfbaa38

    • madhur-tandon: unrelated but the above two statements i.e. import type { AppConfig } from './pyconfig';...

      • madhur-tandon: and now that you deleted the stores below, even the following can be removed: import type {...

      • antocuni: good catch! Fixed by 7ddfb38

    • madhur-tandon: minor nitpick but extra newline 😅

      • antocuni: fine 😅. Killed by 3a27a32

  • Fix typo in passing-objects.md #856 [johnfraney]

    Fixes typo in HTML example: do-mmath -> do-math

    Show Children

    • JeffersGlass: Thanks!

    • tedpatrick: Thanks @johnfraney, Welcome!

    • johnfraney: Thank you! This is a great little project

  • Add display impl, rm outputManage, print and console.log default to browser console #749 [marimeireles]

    This is a WIP, still need to work in tests, but @antocuni wants to see the code, =) Closes #635 #634 #230 #472 #280...

    Show Children

    • fpliger: think this PR is very close to ready to approve. Only needs to fix tests.. or am I missing...

      • fpliger: I think it's ok to start from here but think there are ways we can improve and isolate display...

        • antocuni: I think it's ok to start from here but think there are ways we can improve and isolate display...

        • JeffersGlass: @antocuni Apologies for butting in on this, and the following clarifying questions shouldn't...

        • antocuni: I did want to clarify - what are the situations where you're in the same coroutine but you have...

    • marimeireles: @antocuni this is where we fetch the id.

      • tedpatrick: The <string> casts the return type to a string in TS. Pyodide returns any from calls to...

    • antocuni: good job 💪 Although it definitely misses tests 🍻

      • antocuni: this look like a code smell. Why do we need to check whether out_element has "innerHTML"?

        • antocuni: (I think that the code is outdate, but answering just for the sake of conversation) I think...

      • antocuni: nitpick, but since naming is one of the two hard things in computer science. When I first read...

        • philippjfr: +1

        • marimeireles: This code is not valid anymore :)

    • antocuni: Very good job @marimeireles 🎉. I read and reviewed your commits one by one, in true TDD spirit...

      • antocuni: [fix] if runtime.run(source) raises an exception, the current_display_target is never set back...

        • marimeireles: Thanks! I completely forgot about it. This is what you mean: try { ...

        • antocuni: yes. And ideally, with a test ;) The test is a bit hard to write, but I I guess that with the...

      • antocuni: [style] since we are no longer storing objects but IDs not, the variable should be called...

      • antocuni: I'm confused. If I understand correctly, in this test we want to check that hello in displayed...

      • antocuni: [fix] the comment is wrong. It doesn't fail and we pass an explicit target

      • antocuni: same as above, the comment is wrong

      • antocuni: same as above, the check should be more precise

      • antocuni: [suggestion] these two tests look a bit weird from the outside. If I am testing the behavior of...

        • marimeireles: Well, the difference I'm accounting for here is: is it generated on a py-script tag or a div...

        • antocuni: I'm just saying that I would expect a test for append would check that it actually appends things :)

        • marimeireles: That makes sense... Will try to improve it.

      • antocuni: [nitpick] this smells like a test which tests two different things. In this commit you added the...

        • marimeireles: ❤️ Not hate, grateful for your in depth reviews @antocuni.

        • marimeireles: I thought it'd be too simple to be 2 tests, but I agree. Will change. Cheers.

        • antocuni: ideally, one test should check one thing. The best way to understand is to think about failures....

      • antocuni: you will notice it as soon as you rebase, but <py-env> is gone. You should use <py-config>

      • antocuni: [nitpick] note that with self.console you can do much more precise asserts if you want. E.g. you...

      • antocuni: [style] the name of the variable is wrong: I would expect console_text to be a string (like...

      • antocuni: ah cool, I think this fixes my previous comment. Good job! 💪

      • antocuni: why 0.1? The standard python way to say "please switch to another coroutine" is await asyncio.sleep(0)

    • philippjfr: This is looking great! I do have one question however, is there any way for the user to call...

    • marimeireles: @philippjfr this is pretty easy, I can add it now =)

    • marimeireles: Ah wait, it's already implemented lol 😅 Well, maybe I don't get your question... The user could...

    • philippjfr: No, no you're getting me. I'd have to dig into the code but is get_current_display_target just...

    • marimeireles: Yea it is We just need to document it so people know they can use it 😄

    • marimeireles: I'll add some docs once I fix the failing tests on CI (they are working locally but oh well)

    • antocuni: This is looking great! I do have one question however, is there any way for the user to call...

    • marimeireles: Yes Discuss here: #622

    • philippjfr: I would strongly advise against that and for now I'm -1 to add the possibility to set the...

    • marimeireles: The REPL test that's failing really doesn't make sense... I think they're just haunted. It runs...

    • madhur-tandon: @marimeireles That's because YAML is no longer supported. Only TOML and JSON are.

    • marimeireles: So it's fine to keep it as it is?

    • marimeireles: Ok, so this beauty is finally green, but I had to add a weird fix. I need people who understands...

    • tedpatrick: If we are seeing YAML in the tests, it implies that the branch history is not current in the PR...

    • madhur-tandon: So it's fine to keep it as it is? No no, it means that you have old history, the repo doesn't...

    • antocuni: the presence of this file is wrong and it's probably a merge artifact. It was renamed into...

    • antocuni: If we are seeing YAML in the tests, it implies that the branch history is not current in the PR...

    • antocuni: @marimeireles today I merged #850 which caused another conflict in this branch, so I took the...

    • marimeireles: @antocuni got it! 🎉 Thank you! :) okaaaay I just need one more change. And then we can merge...

    • marimeireles: Ready to merge when the check is green ✅

    • tedpatrick: Awesome work @marimeireles 🚢

    • antocuni: LGTM, good job @marimeireles 🎉🎉🎉

    • antocuni: @marimeireles please please please do not use the default commit message that it's suggested...

    • marimeireles: Docs follow soon.

  • Add note on [[runtimes]] TOML table in docs #861 [tedpatrick]

    Add note on [[runtimes]] TOML table in docs "Note: [[runtimes]] is a TOML table, make sure this is last in a...

    Show Children

    • JeffersGlass: Little thing - probably wants to be “go into the runtimes object”?

      • tedpatrick: goes to go!

    • JeffersGlass: LGTM!

  • Adding docs for display #865 [marimeireles]

    Show Children

    • marimeireles: Oh no this is a rebase mess, I'll open on a new branch.

  • test the testing #560 [pww217] tag: tooling tag: tests

  • Move example to root directory [To Merge with 433] #435 [pww217]

    This has been discussed and from a readability and CI standpoint it makes more sense for examples to live at the...

  • Test fork workflows #559 [pww217]

  • Simple traits example #46 [cleonard] status: declined tag: example

  • Configure Renovate #1 [anaconda-renovate-bot] renovate

    Welcome to Renovate! This is an onboarding PR to help you understand and configure settings before regular Pull...

    Show Children

    • tedpatrick: @pww217 , I would like to close this PR as automated dependency management is problematic for...

    • pww217: Alright, if that's what the team wants. Renovate really will do two things that I think from a...

    • tedpatrick: Thanks, when it is appropriate, we will revisit this.

    • anaconda-renovate-bot: Renovate is disabled Renovate is disabled due to lack of config. If you wish to reenable it, you...

  • Textarea download demo #40 [cleonard] waiting on reporter status: paused

    Show Children

    • tedpatrick: Contributed examples should be submitted as PRs to...

  • Image form demo #39 [cleonard] waiting on reporter status: paused

    Show Children

    • tedpatrick: Contributed examples should be submitted as PRs to...

  • matplotlib to canvas tag example #38 [cleonard] status: declined tag: example

  • [WIP] bootstrap python tests #665 [fpliger]

    Close #617

  • Allowing jest to see dom types. #666 [davidBConda] status: superseded

  • Pin dependencies for pre-commit #860 [woxtu]

    Hi, This PR pins dependencies for pre-commit to match them of the package.

    Show Children

    • tedpatrick: Welcome @woxtu, thank you!

    • tedpatrick: This PR added some great detail to the TS lint issues. Easy to see, easy to fix.

  • Fix eslint error in pre-commit ci #871 [JeffersGlass]

    Fixes an error that causes eslint to fail in specific environments. Let's see if this allows pre-commit CI to pass...

    Show Children

    • JeffersGlass: For what it's worth, the eslint that this change fixed was; "This assertion is unnecessary since...

    • antocuni: brilliant finding! The ESLint behavior is very weird, but it's good that we finally found it :).

  • ts strict - getAttribute #863 [tedpatrick]

    Working through TS strict errors related to getAttribute. Element.getAttribute returns string | null All existing...

    Show Children

    • madhur-tandon: Why a possibility of undefined here? I ask since -- str.split('\\').pop() will always return a...

      • tedpatrick: We will get to that. This PR focuses on types affecting getAttribute only.

      • tedpatrick: looking again...

      • tedpatrick: Oh. the ?. in the next line return str.split('\\').pop()?.split('/').pop();

      • madhur-tandon: Yeah, I mean, why do we need the ?

      • tedpatrick: fixed

    • madhur-tandon: why not use the getAttribute from utils here?

      • tedpatrick: Added

    • madhur-tandon: I guess a linter could fix issues with spacing etc. such as (el:Element, attr:string ) -->...

      • tedpatrick: We need to run prettier but change set is not small. Best later.

    • madhur-tandon

  • skip test_repl as it's flaky #875 [antocuni]

    there is no point having a red build while we wait for the fix. See #864

    Show Children

    • madhur-tandon: Why not mark it as flaky? Also, @tedpatrick did xfail instead on his PR #863

    • tedpatrick

    • tedpatrick: Let's do this as a standalone PR. Perfect.

    • antocuni: Why not mark it as flaky? what do you mean? Do we have a special marker for flaky tests? Also,...

    • madhur-tandon: @antocuni I meant using one of the plugins mentioned here:...

    • antocuni: @antocuni I meant using one of the plugins mentioned here:...

  • use emscripten virtual FS directly to load paths #870 [madhur-tandon] sprint

    Show Children

    • ntoll: The code looks nice and simple... but the tests are failing. Is this expected..?

    • madhur-tandon: The code looks nice and simple... but the tests are failing. Is this expected..? Only 1 test is...

    • antocuni

      • antocuni: [question/style] this line looks very weird to me because you are mixing away and then() which...

        • madhur-tandon: @tedpatrick What do you suggest here?

        • tedpatrick: I suggest we use async/await as we are in a try catch. const response = await fetch(path); const...

        • madhur-tandon: done

      • antocuni: I know that this is a problem which was already present before, but this looks like a good...

        • madhur-tandon: @antocuni I guess the function handleFetchError at...

        • madhur-tandon: actually, I think we can and should remove try...catch blocks from here since loadFromFile is...

        • antocuni: right, it seems like a good idea to me. And of course, we should have a test that checks that...

        • madhur-tandon: done

    • antocuni: LGTM

  • Add type annotations #869 [woxtu]

    Hi, This PR adds type annotations to resolve some ESLint warnings.

    Show Children

    • tedpatrick: Please rebase this to main and all tests should pass. Thanks

    • tedpatrick

    • woxtu: I'm done.

    • tedpatrick: Thanks, Great addition

  • Migrate the Jest config #873 [woxtu]

    Hi, This PR migrates the Jest config to resolve the following warning: $ npm run test > pyscript@0.0.1 test >...

    Show Children

    • madhur-tandon: @woxtu Can you rebase on main? We recently skipped the test that fails -- since it's flaky.

    • woxtu: I'm done.

    • madhur-tandon

    • madhur-tandon: I'm done. Thanks @woxtu!

  • remove warning in docs #828 [madhur-tandon] sprint

    Fixes #819

    Show Children

    • tedpatrick

  • move py-config between body tags #827 [madhur-tandon] sprint

    Closes #820

    Show Children

    • tedpatrick

    • antocuni: It seems I was not quick enough to review this before it was merged 😂. This PR solves the issue...

      • antocuni: this sentence sounds weird to me. It's not "ideal", it's the only place where it is allowed. I...

  • Refactor how py-script are executed, kill scriptQueue store, introduce pyExec #881 [antocuni]

    Yet another refactoring to untangle the old mess. Highlights: base.ts, pyscript.ts and pyrepl.ts were a tangled mess...

    Show Children

    • tedpatrick: Goodbye stores! No issues.

    • madhur-tandon: can remove this comment

      • madhur-tandon: I mean mount_name should be similar to: py_be025f4c_2150_7f2a_1a85_af92970c2a0e

      • antocuni: thanks, killed it in 3eb07da

    • madhur-tandon

    • JeffersGlass: Just curious - what's the advantage of using a function that defines the class rather than just...

      • antocuni: the fact that I can pass runtime from the outside. Note that runtime is used from...

    • JeffersGlass: Love this as a start - having a unified way to intercept and handle errors will be nice, but...

      • antocuni: yes. The next step will be to have an unified place where to display errors when there is no...

    • JeffersGlass

    • marimeireles: Cool PR! :)

      • marimeireles: [question] Why do we have PyScript here instead of pyscript does this mean something different?

        • marimeireles: It stands for the PyScript object I guess... and the other ones are function names?

        • antocuni: to, this is the PyScript class, which now is created at runtime: ...

      • marimeireles: [suggestion/question] I don't understand this name. Could you please explain it to me? This...

        • antocuni: I don't understand this name. Could you please explain it to me? pyExec executes python code...

      • marimeireles: I like this =) I think next step is to actually try to remove all of these ids.

        • antocuni: yes but it's not completely easy because Element.write relies on it. But yes, we should stop...

    • marimeireles: Thanks @antocuni! ^-^

  • Introduce/improve check_js_errors and improve test_no_implicit_target #874 [antocuni]

    Until now, we didn't have a nice way to check that we expect a specific JS error in the web page. This PR improves...

    Show Children

    • madhur-tandon: why not just js_errors = self._js_errors?

      • antocuni: because we modify it in-place later (js_errors[i] = None). I think that in this precise case it...

    • madhur-tandon: should contain only Nones --> should contain only elements which are not None I guess you wrote...

      • antocuni: no, I meant that but I agree that the intent was not very well explained. I tried to improve it...

      • madhur-tandon: Thanks. I took it as a comment for the lines below earlier which were considering non-None...

      • antocuni: yes, if you interpreted it incorrectly it means that it was not clear enough (by definition)....

    • madhur-tandon: newline seems unnecessary here unless some linter ruined this?

      • antocuni: good catch, it was introduced by mistake

    • madhur-tandon: abel --> able

    • madhur-tandon

    • tedpatrick: 🥇

    • marimeireles: PS: @marimeireles look at the individual commits, I followed TDD ;) 😆 Honestly, I have to agree...

    • marimeireles: Thank you for the great work Antonio! This is cool! :)

      • marimeireles: Exactly! ✨

      • marimeireles: [question] Why are we cleaning it here?

        • antocuni: because self.check_js_errors() is also automatically called at teardown, after executing each...

      • marimeireles: [fix] You're saying we're raising JsMultipleErrors but this code was renamed to...

        • antocuni: good catch! Fixed by 3a8a64e

      • marimeireles: [typo] Represents (?)

        • antocuni: No, the convention in python docstrings is to prefer use the imperative than the 3rd person. See...

      • marimeireles: [suggestion] Maybe we should reword the doc string for console.all? Since the above is now different.

        • antocuni: thanks, fixed by 9fb4ff5

    • antocuni: Honestly, I have to agree it's a great method. I'm using it right now on my PR to remove code, I...

  • Reference Docs #888 [tedpatrick]

    Add Reference Elements & Modules to docs for <py-script> <py-config> <py-repl> Fixes #847 Fixes #849 Fixes #846

    Show Children

    • fpliger: Thank you @tedpatrick !! THis is an excellent PR! Left some comments but overall lgtm

      • fpliger: Very minor comment... For readability, I'd move the "Notice here... " after the example. Maybe a...

      • fpliger: I'd add something like: Package dependencies in the config can be declared by using the direct...

        • tedpatrick: added

      • fpliger: I think it'd be extremely valuable to users if we provided an example of a full configuration...

        • tedpatrick: Added complete schema in json + toml as examples

      • fpliger: format -> schema ?

      • fpliger: left over?

  • Fix bug in docs #889 [tedpatrick]

    header for py-repl table

  • try to display a reasonable message if you run a bare 'pytest' command #890 [antocuni]

    The docstring says everything: At the moment of writing this conftest defines two new options, --dev and ...

    Show Children

    • marimeireles: I like it! Thanks @antocuni. Why is it a WIP?

    • antocuni: Why is it a WIP? because I forgot to mark it as ready 🤦‍♂️ . Can you please approve it ?

    • marimeireles: LGTM

    • madhur-tandon

  • Simplify pyrepl.ts and kill base.ts #884 [antocuni]

    Yet another of my refactorings. This PR does two things which are related but also clearly separated, and probably...

    Show Children

    • fpliger: Since you are touching this, we should also allow source to be defined form a src file and not...

      • antocuni: Actually I already started to add it, but then I stopped because it raises too many open...

      • fpliger: Ok, let's cover this in a follow-up PR. (And semi-related, I'm also starting to think that we...

    • fpliger: This means no more than one code-editor (aka, py-repl) per page. I suppose this is...

      • antocuni: I am aware that it's a problem, but it's not a new bug, the main branch has the same logic: ...

      • fpliger: Right.... not sure when this was introduced but, yeah, it's a bug. +1 on fixing it with a follow-up PR

    • fpliger: So, this means we always create the output div, even if we have an explicit output attribute?

      • antocuni: yes, I did it intentionally because it simplify handling the case in which output=... points to...

      • fpliger: I don't think it does and I'm probably too picky here. It just leaves an unused empty tag which...

    • fpliger: I know this PR is WIP but thought I'd leave early feedback. Great work ;)

    • antocuni: I know this PR is WIP but thought I'd leave early feedback. Great work ;) actually when you...

    • marimeireles: This entire file looks good to me 👍 Should I review the rest too?

      • antocuni: This entire file looks good to me 🎉 Should I review the rest too? reviews are always welcome :)

    • tedpatrick

    • tedpatrick: solid

    • woxtu: 👀 Suggested change ...

    • fpliger: 🚀 🚀 🚀 🚀

  • remove another pytest_configure #894 [madhur-tandon] sprint

    Show Children

    • antocuni: LGTM

  • Retain path structure for loading paths #845 [madhur-tandon] sprint

    This addresses #519 While packages are not determined automatically for now, but at least the structure is retained...

    Show Children

    • tedpatrick: [question] if we get paths without __init__.py, should we make one?

      • madhur-tandon: You mean, if we only have ./utils/a.py for example? I think yes, it is better to always remain...

      • tedpatrick: [question] In terms of local modules, I assume we need a __init__.py even if the file is empty?

      • antocuni: no, it's conceptually wrong to create an __init__.py if it's not specified, for two...

    • tedpatrick: [question] Do you need f.close() here?

      • madhur-tandon: tmpdir in pytest is of type <class 'py._path.local.LocalPath'> and thus it doesn't have a close...

    • JeffersGlass: Thanks @madhur-tandon! This is a great start on being able to load structured packages. I think...

    • antocuni: I commented on the original issue, to avoid having two parallel conversations. Let's continue...

    • antocuni: I have the same concerns as @JeffersGlass : I think we should have a more complete solution for...

      • antocuni: [suggestion/fix] as you have noticed, self.tmpdir is an instance of py.path.local (which is a...

        • madhur-tandon: done, thanks!

    • antocuni: does this mean that if I do this: paths = ['a/b/c/foo.py'] it won't work because I need to...

      • madhur-tandon: No, so, the parent of a in this case is nothing but the root of the filesystem which will always...

      • antocuni: so this is basically an assertion? Then better to make it clear, because it wasn't clear to me...

      • madhur-tandon: yeah, guess I should change it, thanks!

    • antocuni

    • madhur-tandon: @JeffersGlass We are going to merge this and tackle the implementation of the proposal by...

    • JeffersGlass: Sounds good to me! Thanks @madhur-tandon

    • JeffersGlass: We should note that this currently doesn't allow for the use of fully qualified URL's, which was...

    • madhur-tandon: this currently doesn't allow for the use of fully qualified URL's Yeah, that is the next step...

    • JeffersGlass: We should note that this currently doesn't allow for the use of fully qualified URL's, which was...

    • antocuni: We should note that this currently doesn't allow for the use of fully qualified URL's, which was...

  • Upgrade to Pyodide 0.21.3 #887 [JeffersGlass]

    Upgrade to Pyodide 0.21.3 as the default. The changelog from 0.21.2 -> 0.21.3 is mostly bug fixes (including a...

    Show Children

    • tedpatrick: odd test-ts error (node:46904) ExperimentalWarning: VM Modules is an experimental feature. This...

    • JeffersGlass: Huh! Interesting… will investigate.

    • JeffersGlass: It's curious to me that the error can't find a file in .../node_modules/src/js/... , which...

    • antocuni: this very vaguely rings a bell to me. I think that @madhur-tandon had problems when migrating to...

    • madhur-tandon: @madhur-tandon had problems when migrating to 0.21.2 Yes, this is possible it's the same issue....

    • antocuni: while integration tests run through selenium. I guess you mean playwright here

    • madhur-tandon: I guess you mean playwright here Yeah, I guess I typed in hurry 😓 And that's probably because...

    • madhur-tandon: @JeffersGlass I did something similar in my previous attempt -- using the indexURL property, I...

    • tedpatrick: Perfect

    • madhur-tandon: Seems like the test for loading a local pyodide passes, approving 🗡️

    • JeffersGlass: Y'all were exactly right, the issue was in differences between running in Jest vs in...

    • tedpatrick: Yours to merge @JeffersGlass

    • madhur-tandon: I believe this broke in 0.21.3 build (and not 0.21.2) What is strange is that it broke in...

  • Format the TypeScript files #877 [woxtu]

    Hi, This PR just ran Prettier to format the TypeScript files.

    Show Children

    • antocuni: Please don't merge :) I don't have anything against this PR, and thank you for submitting...

    • madhur-tandon: I think we can (and probably should) also wait for #884 to land first.

    • madhur-tandon: @woxtu could you rebase on main and then run the formatter again?

    • woxtu: Sure.

    • madhur-tandon

    • antocuni

  • Fix py-repl docs #896 [tedpatrick]

    remove attribute exec-id remove attribute root

    Show Children

    • madhur-tandon: @tedpatrick I see that these elements are not really eliminated ...

    • tedpatrick: They are internal use only for child py-repl elements. They should not be documented.

    • madhur-tandon

    • tedpatrick: 🚢

    • marimeireles: Thank you!

  • Add more type definitions #882 [FabioRosado]

    I started adding some types in an effort to fix #834 but Jeff discovered the issue and fixed it 😄 This PR adds a bit...

    Show Children

    • antocuni: ouch, sorry to stumble upon your feet, but note that in PR #881 I'm doing (yet another 😅) heavy...

    • FabioRosado: ouch, sorry to stumble upon your feet, but note that in PR #881 I'm doing (yet another...

    • marimeireles: Types! 🤩

    • FabioRosado: I'm waiting for #884 to get in before I rebase 😄

    • antocuni: I'm waiting for #884 to get in before I rebase smile yes, after #884 I don't have any major...

    • fpliger: Nice PR! Thanks @FabioRosado yes, after #884 I don't have any major refactoring planned :) .... yet 😆

    • madhur-tandon: @FabioRosado this should be rebased now since #884 is merged now 😅

    • madhur-tandon: Rebase required 😅

    • madhur-tandon: @FabioRosado Yours to merge when the tests pass :)

    • FabioRosado: Thanks @madhur-tandon I can't merge it though 😄 Just ran npm run lint and noticed some more...

    • madhur-tandon: I'll probably will open a follow up PR with them once I'm done unless this PR is still open then...

    • fpliger

    • FabioRosado: @antocuni just checking, should pytitle call ensureUniqueId as well?

      • antocuni: I think that py-title should die in flames 😅. Looking at the code I think it should because it's...

      • FabioRosado: Haha removing things is always fun! Awesome I just wanted to be sure that I didn't removed...

    • FabioRosado: There are still about 71 warnings but a lot of them are coming from pyodide since most of the...

    • tedpatrick: Awesome work

  • Add Fabio Rosado as PyScript Maintainer #899 [tedpatrick]

    Welcome @FabioRosado as maintainer

    Show Children

    • ntoll

  • Add display docs #866 [marimeireles]

    Show Children

    • JeffersGlass: This display() effort and the docs to go with it are swell! Just a couple of little thoughts for...

      • JeffersGlass: Probably worth adding which is the default value for this.

      • JeffersGlass: This reads to me like values is a list of str, where each value can be one of the following...

        • marimeireles: Yeah you are, doing stuff like display('a', 'b', matplolib_img, ...) Should be possible. Open to...

        • JeffersGlass: Hmmmm what about something like: *values - the objects to be displayed. String objects are...

        • marimeireles: No I like that, I think it's fine. I think it might be clearer for people =) Thanks Jeff!

    • marimeireles: This is a bit annoying because we're discussing new ways of changing display again, but I think...

    • marimeireles: Coolio, thanks @JeffersGlass! And thanks @tedpatrick for the update on the docs organization...

    • JeffersGlass: LGTM!

    • tedpatrick: Isn't display a built-in module...

    • antocuni: Isn't display a built-in module currently? display is a function defined in pyscript.py: ...

  • Fix py-repl auto-generate=true #910 [antocuni]

    What is not tested is broken 🤦‍♂️ Test&fix <py-repl auto-generate=true> which was broken by PR #884

    Show Children

    • marimeireles: I'm gonna extra test this one. Thanks @antocuni!

    • marimeireles: Beaautiful ✨

    • antocuni: Beaautiful plase approve it, else I cannot merge 🤦‍♂️

    • marimeireles: Gr8!

    • madhur-tandon: siny --> I think you meant since?

      • antocuni: thanks, fixed

  • display() should escape by default #915 [antocuni]

    Before this PR, display(some_str) and display(some_obj) used to put the result directly in the .innerHTML of the...

    Show Children

    • fpliger: I don't remember whether we wrote it down anywhere, but I'm pretty sure that this is what we...

    • antocuni: if you want to inject some raw HTML in the output, you can use the new HTML class:...

    • fpliger: Because the HTML class implements the repr_html method and it works out of the...

    • antocuni: It may be me (and may even being super pedantic).. don't really love the all caps HTML compared...

    • fpliger: I think that the official name of the language is HTML (uppercase) ;). But also, in Python there...

    • antocuni: Can someone approve this please?

    • tedpatrick

  • Add development section to our docs #920 [FabioRosado]

    This is the first pass at adding a development section for our docs, I've moved setting up your env and developing...

    Show Children

    • antocuni: LGTM

      • antocuni: I'm not really sure that it's a good idea to try to teach git in a few paragraphs: for people...

        • FabioRosado: Yeah that's a good point! when I started using Git, rebase was confusing to use that's why I...

    • antocuni: Perfect, thank you! Our "merge etiquette" prescribes that PR authors do the actual merge after...

    • FabioRosado: Sounds good, I'll hit merge then!

  • Create error or warning level banners and allow users to close it #909 [FabioRosado]

    I've hacked something quickly based on the discussion on #897 (comment), this PR adds a new util called...

    Show Children

    • antocuni

      • antocuni: uhm, this is not what I had in mind. What I had in mind was something like this (mostly...

        • FabioRosado: Ah gotcha! I created the exception but didn't think about the handler, this makes...

        • antocuni: well, then it's a warning and not an error IMHO 😅

      • antocuni: genuine question: is this considered a good way to inline svg elements? I would expect at least...

        • FabioRosado: Good question, you can do this kind of things in React when you want to create a SVG icon (kind...

    • antocuni: Some questions I haven't removed showError yet, because I'm a bit unsure about the name...

    • FabioRosado: * `_createAlertBanner` which is just an implementation detail * `showWarning` which uses...

    • antocuni: * `_createAlertBanner` which is just an implementation detail * `showWarning` which uses...

    • antocuni: Very good job, thank you! Left some minor comments but in general I'm happy with it

      • antocuni: do we still need showBanner? Again, if it's an error it should be showed, else it's not an...

        • FabioRosado: Good question, I was thinking that in the future we might need, but I am happy to remove it and...

        • antocuni: yes, +1 to kill code-which-we-dont-need-now. If it's not present, it cannot be buggy 😅

      • antocuni: "funny". I think that originally I put the + because I split the message on two lines. I don't...

        • FabioRosado: Oh I joined them because the banner was showing them on the same line 🤔 I'll add a to split it up

        • antocuni: I mean, I split them in the src code only because the line was too long and it didn't fit my...

      • antocuni: woooo, a big and obscure comment deleted 🎉

      • antocuni: this is a good example of why the new approach is much better than the old one. I think that...

        • FabioRosado: That makes sense, I was wondering what we should do here, I'll raise the exception then thanks!

      • antocuni: this function deserves a docstring IMHO :). But also, I wonder whether it should go to e.g....

        • FabioRosado: Originally I was thinking to put it in exceptions, but then wondered if it was the right place...

      • antocuni: [question] neat, I didn't know you could use document from jest tests. I guess it's using a fake...

        • FabioRosado: I learned this recently, all my previous attempts failed when i tried to check if something was...

    • antocuni: LGTM, feel free to merge! Thanks!

    • FabioRosado: Thanks! I need to look at the test failures that had different errors locally but I think they...

  • use user error for paths calculation #927 [madhur-tandon] sprint

    Use the new UserError paradigm by @FabioRosado

    Show Children

    • tedpatrick

  • implement proposal for fetching paths and retaining structure of dirs and packages #914 [madhur-tandon] sprint

    Closes #519 and #921 Proposal here: #519 (comment) TODO: Update docs

    Show Children

    • antocuni: Good job, apart a couple of notes. But, it completely misses integration tests which should to...

      • antocuni: [suggestion] This example has the purpose of showing that you can use both src and inline...

        • madhur-tandon: done, using packages

      • antocuni: I think it's fine for this PR, but we should have better docs to explain how this...

        • madhur-tandon: I guess you cannot see an entry for to_file here as well since I think you reviewed a previous commit.

      • antocuni: why did yoy put this code into utils.ts? It's specifically for py-config, it should go into pyconfig.ts.

        • madhur-tandon: put it in plugins/fetch.ts as discussed on slack

      • antocuni: [question] just my curiosity but: what is the advantage of using forEach instead of a normal for...

        • madhur-tandon: I don't know to be honest except that it is considered a standard practice I guess? If not, I...

        • antocuni: I don't really know because I'm not an expert of JS/TS. In all the rest of the code we use...

      • antocuni: this is missing support for to_file as described here: #519 (comment)

        • madhur-tandon: @antocuni I think you reviewed a previous commit. I already added support for to_file. Not sure...

        • madhur-tandon: resolving...

      • antocuni: I have no idea what this line does :). Sure, I could probably spend 5 minutes trying to...

        • madhur-tandon: done, added testing, the part about filter(it => it !== "") is needed since the behaviour...

      • antocuni: oh, and this is the 3rd time you copy&pasted the code. One more reason to make it a standalone function

        • madhur-tandon: done

      • antocuni: small note: if PR #909 gets merged before this one, this shoud become throw UserError.

        • madhur-tandon: Done in #927

    • madhur-tandon: @antocuni For the integration tests, they were present in test_01_basic.py, I have moved it to...

    • antocuni: I am not sure if we should write tests using a custom URL (eg: http://example.com/data.csv) --...

    • antocuni: good job 💪 I'm approving it in advance so that you can merge it without any further review from...

      • antocuni: this looks wrong. If I do jointPaths("/tmp", "foo.txt") I expect /tmp/foo.txt, not tmp/foo.txt

        • madhur-tandon: Done, I only check for a leading slash on the first element though. Otherwise it will be very cumbersome.

  • decode innerhtml for pyconfig #926 [madhur-tandon] sprint

    Fixes #925

    Show Children

    • FabioRosado

    • madhur-tandon: Thanks @FabioRosado.

    • antocuni: this is definitely missing a test 😢

    • madhur-tandon: this is definitely missing a test 😢 Added here: #929

  • add test for not escaping characters in pyconfig #929 [madhur-tandon] sprint

    Show Children

    • tedpatrick

    • madhur-tandon: Thanks @tedpatrick

  • Introduce a Plugin system, implement <py-terminal> as a plugin #917 [antocuni]

    This PR does two things: introduce the first minimal version of a Plugin system. Plugins are subclasses of the...

    Show Children

    • FabioRosado: Just had the smallest of comments but this looks good! I'll open an issue so I dont forget to...

      • FabioRosado: Just a nit, but would be nice to have a more discriptive name although the code is small enough...

        • antocuni: I'm following this rule here. The point is precisely that the code is short, and having a longer...

      • FabioRosado: Do we need to add typing here or does TS knows msg will be string?

        • antocuni: Uhm, good question, I don't really know. I tried to compile with --strict and the compiler...

      • FabioRosado: +1 on this 😄

    • antocuni: @FabioRosado I think this is ready to be merged, but I'll let you decide about the naming of t :)

    • FabioRosado: I think it's okay like you said the code is small enough that it doesn't affect understanding of...

  • Fix banner width #930 [FabioRosado]

    @JeffersGlass noticed that the border of the banner cut off on the right side. I've tested this and seems like...

    Show Children

    • madhur-tandon: @FabioRosado could you perhaps post a screenshot?

    • JeffersGlass: LGTM

    • JeffersGlass

    • FabioRosado: Thank you Jeff and thank you for the screenshot I forgot to add those 😬

  • Improve Detection of Scripts that Require Top-Level Await #715 [JeffersGlass] status: superseded

    Issue As noted in #714, testing whether a script needs to run with top-level-await enabled by looking for 'asyncio'...

    Show Children

    • JeffersGlass: For what it's worth, this PR is not necessarily dead, but I've been deprioritizing it since it...

    • tedpatrick: If we were explicit about denoting a <py-script> element instance as sync or async, would we...

    • JeffersGlass: @tedpatrick That would depend exactly what the 'sync' and 'async' modes do, which I don't think...

    • JeffersGlass: The code in this PR has been folded into #928 - with the deprecation of Implicit Coroutine...

  • Make HTTP cache persisten across sessions #936 [antocuni]

    This allows to run tests offline (if the cache is already populated), and to make them much faster if you are on a...

    Show Children

    • philippjfr: Obviously this isn't a priority but it might be nice to eventually move some of this machinery...

    • tedpatrick

    • antocuni: Obviously this isn't a priority but it might be nice to eventually move some of this machinery...

  • Raise error if we get a non 200 status from fetch #935 [FabioRosado]

    This PR adds a check to the status code of fetch and if we get any non 200 then we throw an error. This was a bit of...

    Show Children

    • FabioRosado: Nice pre-commit hook! The local env in my personal laptop is messed up, will fix tomorrow

    • antocuni: uhm, maybe we could raise some custom subclass of Error here? This way, we could do a more...

    • FabioRosado: I really dislike the double check for TypeError so the test passes but looking at the code and...

    • antocuni: I really dislike the double check for TypeError so the test passes but looking at the code and...

    • antocuni

    • FabioRosado: Oh! Today I learned ha Thanks that makes sense! So the assertion might be okay

  • WIP: Fix Typescript errors in strict and eslint warnings #939 [FabioRosado]

    I'm opening this as a WIP since we will chat as a team about typing. This PR contains the work so far on addressing...

    Show Children

    • madhur-tandon: I guess we got conflicts hehe.

    • FabioRosado: haha yeah and I guess more will come soon 😄

  • Export Runtime from PyScript Module #868 [JeffersGlass]

    Adds an export to the pyscript.js module that exposes the app's RunTime object. This allows users to interact...

    Show Children

    • tedpatrick: We clearly need to have more community calls, it seems to generate PRs. 🚀

    • fpliger: This is an EXCELLENT PR!!! Awesome job @JeffersGlass !! Only comment (thinking out loud...

      • fpliger: Imho, adding an example here would be helpful

    • fpliger: Oh, also forgot to mention, would be good to add a couple of quick tests out of the examples in the docs.

    • JeffersGlass: Thanks @fpliger! Agreed, as we move into having more runtime options down the road (and/or...

    • antocuni: I didn't notice this PR, I'm coming here only now because I stumbled across the relevant line. I...

    • JeffersGlass: All very good points @antocuni - my solution here is a pretty blunt sledgehammer to solve a...

    • antocuni: We should probably move discussion of the API you propose to a new proposal/issue? I too would...

  • remove unneeded import #945 [madhur-tandon] sprint

    Show Children

    • FabioRosado: Thanks!

  • remove one more unneeded import #946 [madhur-tandon] sprint

    Show Children

    • FabioRosado: Oh yeah I remember removing this one in my draft PR now haha thanks!

  • Deprecate py-button, py-inputbox, py-box and py-title #931 [FabioRosado]

    This PR adds a deprecated banner to any of these elements, updates the examples and docs. For one of the examples we...

    Show Children

    • JeffersGlass: If you wanted, you could also add a note under the "Visual Component Tags" header that all of...

    • FabioRosado: Thanks that's a great idea! I'll push a commit to add the note and also mention the warning...

    • JeffersGlass: Another small thing I don't feel strongly about - currently, there's one warning banner per...

    • JeffersGlass: Ah yes, so the current py-[event] syntax doesn't allow for passing the event object to the...

    • FabioRosado: Another small thing I don't feel strongly about - currently, there's one warning banner per...

    • FabioRosado: Just pushed a change to create a single banner per element 😄

    • JeffersGlass: Nice touch!

    • JeffersGlass: So this relies on innerHTML to include the elementName to detect duplicates, but doesn't...

      • FabioRosado: That could be a nice approach, although I think that createDeprecationWarning will only exist...

      • JeffersGlass: Makes sense to me!

    • JeffersGlass

    • FabioRosado: Thanks Jeff!

  • draft: add basic syntax highlighting for vim #161 [kmod]

    It made me sad to see unhighlighted code during Peter's keynote :( I took a quick stab at vim syntax highlighting...

    Show Children

    • tedpatrick: Thank you for your PR contribution to PyScript. We are closing PRs older than 90 days with...

  • Created tag <py-for> to perform iterative operation on HTML and added example #256 [Rjtsahu] status: paused tag: component

    Hey Team, While using the pyscript, I have come up with problems in rendering where you want to do iterations, right...

    Show Children

    • tedpatrick: Thank you for your PR contribution to PyScript. We are closing PRs older than 90 days with...

  • add : japanese translation to doc #389 [obutora] status: paused tag: docs waiting on feedback

    I'm excited to see such a great project!! Pyscript has become a big topic in Japan, and many engineers want to use...

    Show Children

    • tedpatrick: Thank you for your PR contribution to PyScript. We are closing PRs older than 90 days with...

  • add : korean translation to doc #445 [codevilot] status: paused tag: docs waiting on feedback

    I think it's a paradigm shifting project. I just saw a post related to Pyscript and I really liked it, so I...

    Show Children

    • tedpatrick: Thank you for your PR contribution to PyScript. We are closing PRs older than 90 days with...

  • Added Internet Requirement For Getting Started. #549 [Tosin-JD] waiting on reporter tag: docs

    I updated the getting started to show help beginners ensure that they have a constant internet connection to access...

    Show Children

    • tedpatrick: Thank you for your PR contribution to PyScript. We are closing PRs older than 90 days with...

  • Evaluate dynamically added <py-script> tag #690 [hoge1e3] waiting on reporter status: superseded

    In original version, the element created by document.createElement("py-script") after pyodide runtime initialization...

    Show Children

    • JeffersGlass: I believe this PR has been superseded by the work in #881; the...

    • tedpatrick: Thank you for your PR contribution to PyScript. We are closing PRs older than 90 days with...

  • Created PyScript alternative to document.queryselectorAll() #702 [LoreBadTime] waiting on feedback

    Now with this patch you can get a list of Element Objects from the Elements class,using CSS selectors(implemented...

    Show Children

    • tedpatrick: Thank you for your PR contribution to PyScript. We are closing PRs older than 90 days with...

  • Add flag to send HTML or plain Text to banner #947 [FabioRosado]

    This is a small PR that changes how the _createAlertBanner works, before this, we were adding the message to...

    Show Children

    • madhur-tandon

    • FabioRosado: Thanks!

  • use a const for run button svg #948 [madhur-tandon] sprint

    This follows the approach for what is done with CLOSEBUTTON

    Show Children

    • tedpatrick: empty id=""

      • madhur-tandon: removed, thanks!

    • tedpatrick: Do we use CLOSEBUTTON and RUNBUTTON outside of <py-repl>? if no, why not keep them local to...

    • madhur-tandon: Do we use CLOSEBUTTON and RUNBUTTON outside of <py-repl>? CLOSEBUTTON is used in exceptions.ts...

    • madhur-tandon: Re-running CI because of Timeout on one of Integration Tests.

    • tedpatrick: If RUNBUTTON is limited to <py-repl>... isn't that where it should live? If we make a plugin of...

    • madhur-tandon: If RUNBUTTON is limited to <py-repl>... isn't that where it should live? Yeah, makes sense. I...

    • fpliger: 👍

    • tedpatrick: I just want dependencies tracked against where they are used. Use your best judgment there and 🚢 it.

    • FabioRosado: Ah yeah that's my fault 😄 I introduced the consts file thinking that we could perhaps keep all...

    • FabioRosado

    • madhur-tandon: Thanks! I have removed the consts.ts file introduced by @FabioRosado for now. If needed, we can...

    • madhur-tandon: @FabioRosado Seems like one of the tests were broken, I have fixed it, can you TAL? Seems like...

    • FabioRosado: @FabioRosado Seems like one of the tests were broken, I have fixed it, can you TAL? Seems like...

    • madhur-tandon: Want me to open a quick fix for it? I will push some commits fixing it here, but will request...

    • FabioRosado: Apologies for the ping, I ran the tests in main and it passes, but pulling this branch it fails....

    • madhur-tandon: Did you rebase main into the branch? 🤔 Yeah, I did, so it shouldn't error out, right?

    • madhur-tandon: @FabioRosado actually, the CI fails on main too, so there is a problem. Will fix and push here only.

    • FabioRosado: @FabioRosado actually, the CI fails on main too, so there is a problem. Will fix and push here...

    • madhur-tandon: seems like I forgot to update the messages when merging that PR 😞 If you have them ready...

    • FabioRosado: seems like I forgot to update the messages when merging that PR 😞 If you have them ready...

    • madhur-tandon: @FabioRosado merged yours, rebased and force pushed :)

  • Fix deprecated message and tests #950 [FabioRosado]

    When working on #924 I forgot to change the deprecated message, since we are sending text by default, the escaped...

    Show Children

    • madhur-tandon: Thanks a lot, let's wait for everything to go green :D

    • FabioRosado: no worries sorry about this and yeah good idea 😄

    • madhur-tandon

    • FabioRosado: Thank you Madhur!

  • Zip the build folder and add it to release #949 [FabioRosado]

    I used act to check if this would run successfully (using dry-run) and got a green checkmark, hopefully it will work...

    Show Children

    • tedpatrick

    • madhur-tandon: [question] What is act? PS -- Yeah, makes sense to use zip since it should be available in the...

    • madhur-tandon

    • FabioRosado: [question] What is act? PS -- Yeah, makes sense to use zip since it should be available in the...

    • pww217: Cool - not sure if the runner necessarily has zip but it is an Ubuntu base so it probably...

    • pww217: Oh actually ignore me this is a public runner

    • FabioRosado: Awesome thanks 😄

  • Add basic docs for py-terminal #933 [FabioRosado] tag: docs tag: plugins

    This PR adds a very basic entry on py-terminal and a new section in Reference for plugins. @antocuni Is there...

    Show Children

    • antocuni: Thanks! Left some suggestions

      • antocuni: Suggested change ...

      • antocuni: Suggested change ...

      • antocuni: Suggested change ...

      • antocuni: Suggested change ...

      • antocuni: I would also add a note which explains that you can place a <py-terminal> manually (and you can...

    • FabioRosado: I am not sure if Github allows you to batch multiple suggestions and add them in a single commit...

    • antocuni: sorry for the confusion 😅. This is not needed. The semantics is that if the user puts one or...

      • FabioRosado: Oh gotcha!

    • antocuni: LGTM

      • antocuni: typo :) Suggested change ...

        • FabioRosado: Great catch thank you!

  • version number in build #953 [tedpatrick]

    Show Children

    • fpliger: pinging @FabioRosado as a pin for us to keep in mind for the nest release

    • antocuni: there must be a better way to automatically get it from the git tag, mustn't it?

    • fpliger: Great! 🚀 now go

    • fpliger: @antocuni there is. Ted mentioned it was getting too complicated. FWIW, manual is better than...

    • tedpatrick: Infinity better than <<VERSION>>

    • antocuni: Ted mentioned it was getting too complicated. FWIW, manual is better than none and does the job...

    • tedpatrick: I had to turn on Rollup JSON injection, then TS complained, then tests broke, then, then, then.

  • More plugins: splashscreen and importmap #938 [antocuni] tag: plugins

    This PR move codes from main.ts into two new plugins: splashscreen (formerly known as py-loader) importmap The old...

    Show Children

    • tedpatrick: 🤩

    • tedpatrick: 🤿

    • FabioRosado: Apologies for the delay, this looks great!

      • FabioRosado: Nice!

      • FabioRosado: This was already in the previous code, but I just noticed it now haha ...

      • FabioRosado: Nice! this is much better 😄

  • Remove the remains of svelte #886 [FabioRosado]

    This PR removes the last remaining of svelte 😄 Locally the simply_clock failed on every run, but after testing main...

    Show Children

    • madhur-tandon

    • tedpatrick: Awesome work @FabioRosado

    • antocuni: awesome, thank you :)

  • Update contributing docs and remove lint from makefile #779 [FabioRosado]

    This PR adds a bit more information on how to develop locally, it mentions activating the conda env so pre-commit...

  • Remove 'Implicit Async', Don't Await `runtime.run()` #928 [JeffersGlass] status: ready

    This removes the ability to write "implicitly scheduled coroutine" code in <py-script> tags, and requires users to...

    Show Children

    • antocuni: woooo 🎉🎉🎉

    • JeffersGlass: Interesting error in test_py_config: "DeprecationWarning: There is no current event loop'" shows...

    • JeffersGlass: I added docs explaining the deprecation of implicit coroutine scheduling; the added...

    • marimeireles: Hey @JeffersGlass just to confirm. This is not a WIP anymore, right? Maybe you can morph it into...

    • JeffersGlass: This is not a WIP anymore, right? Whoops! You're correct - I've removed "WIP". Thanks! I didn't...

    • madhur-tandon: Docs build upload is failing too... but that's just the upload, not the build, which I think is...

    • marimeireles: I'm a +1 thank you for your work here, this is great improvement! :)

    • madhur-tandon: Great PR!

    • FabioRosado: Should the return type be void instead? 🤔

      • JeffersGlass: I knew I should have gotten coffee before committing. Thanks Fabio!

      • FabioRosado: Haha I mean I guess void is kindof null? 😄

    • JeffersGlass: Thanks y'all! I do want to give @antocuni a chance to weigh in here before I hit merge, since...

    • antocuni: Very good and solid PR, I love it! Goodbye implicit async ☠️ 👋 🔥 Left some minor comments, but...

      • antocuni: I'm confused: why does it still return a promise?

        • JeffersGlass: An oversight on my part - fixed!

      • antocuni: this is probably worth writing a couple of unit tests in tests/py-unit probably?

        • JeffersGlass: Tests added

      • antocuni: just thinking aloud, but I wonder whether we should provide pyscript.run_async, which would...

        • JeffersGlass: Hmmm interesting - definitely worth revisiting as we revamp the Python API. I like the idea.

      • antocuni: oh, thank you for fixing this :)

    • JeffersGlass: 🚀 This breaks the brand new test_importmap from #938 in exactly the way explained there -...

    • antocuni: awesome tests 😍

  • Cleanup `runtime.run` awaits #957 [JeffersGlass]

    With the merge #928 (runtime.run is no longer async), I realize I missed several spots where we were still awaiting...

    Show Children

    • FabioRosado: Awesome thank you! 😄

    • antocuni: wow, I didn't know that in JS it's legal to await a non-promise 🤦‍♂️ I wonder what was the...

  • Handle non-200 code when fetch py-script src #940 [FabioRosado]

    I noticed the comment about not handling errors when we fetch the src from py-script, this PR handles any non-200...

    Show Children

    • JeffersGlass: You're work on the warning/error messages is really paying off Fabio! Really liking it a...

    • FabioRosado: Oh Thats a great point, thank you! I'll push a commit to clean the inline code in case folks do...

    • madhur-tandon: LGTM, but you could also check if the innerhtml is cleared in the test. Thanks again, this is great!

    • FabioRosado: Thanks! Pushed the assertion that inner html is empty as well will merge 😄

    • antocuni: Not that inline code and src should ever be mixed, since the latter takes precedence over the...

  • Add `PyScript.__version__` and `PyScript.version_info` #833 [JeffersGlass] status: superseded

    Edit: See updated spec proposal below Addressing #546, this is a WIP to add the ability for users to check the...

    Show Children

    • JeffersGlass: Bonus note - since all the other attributes of the PyScript class are either @classmethod's or...

    • tedpatrick: The plan was to stamp the version into Pyscript.js here This then goes into <py-config> and is...

    • JeffersGlass: At long last, I think this is ready for review. Apologies for it taking so long, I had a lot to...

    • JeffersGlass: Edit: See updated spec proposal below Updates: PyScript.__version__ and PyScript.version_info...

    • tedpatrick: I think the only remaining item on this is getting the version_number into the build.

    • JeffersGlass: @tedpatrick I'm not quite sure I know which part of the build you mean. Edit: Oh, do you mean...

    • tedpatrick: "2023.04.2.RC2" needs to be stamped into the output JS during the build process. I believe it...

  • Add div id to target in the display so examples get displayed in the right tag #955 [FabioRosado]

    Some examples had a div with an id and we were rendering things onto this div, in some cases (like Altair) this div...

    Show Children

    • antocuni: the target= is good, but now you can also remove the output attr in <py-script output=...>

      • FabioRosado: Oh good point thanks! I'll remove it in the next push

      • antocuni: 👍

  • [DOCS] fix & event-handlers #852 [dj-fiorex] tag: docs

    Fix markdown Add event-handlers.md

    Show Children

    • marimeireles: Wow! Great work! 🎉 Thank you so much for these ☺️

    • marimeireles: closes #835

    • antocuni: Thank you for this PR @dj-fiorex! I have added a small suggestion but overall it looks very...

      • antocuni: this is not technically correct. The value of the attribute can be any arbitrary python code...

    • JeffersGlass: This section and the following one seem to be identical to the text in passing-objects.md. We...

      • dj-fiorex: That is identical because the section "passing-objects" is a very broad argument, but I think...

      • JeffersGlass: I agree that they're related, but I don't think it merits having duplicate content - almost all...

      • antocuni: I agree with Jeff: let's avoid duplication and put cross-reference links instead. It is easier...

    • JeffersGlass: Hi @dj-fiorex! Just wanted to check in about this PR - it's really great work, I think it could...

    • dj-fiorex: Hello sorry for the delay, I will fix this next week!

  • Import PyScript Version into Python Runtime #958 [JeffersGlass]

    After Ted's PR earlier this week (#952), here's a small-ish PR to access that version in Python as well. It adds...

    Show Children

    • antocuni

      • antocuni: do we really want to add the .final? If the URL is pyscript.net/releases/xxx/, then __version__...

        • JeffersGlass: Hmm yeah, 'final' is a bad example here. I'll change it to 2023.02.1.dev or similar.

      • antocuni: ah, this seems to contradict my previous comment. But then I don't understand how "normal"...

        • JeffersGlass: So I figured if the "canonical" name of the version is "2022.09.1.RC2", then version_info should...

        • madhur-tandon: I am inclined towards final or release instead of "" but have no strong opinions to be honest.

    • JeffersGlass: Sadly, this breaks in pyodide.test.ts in a very strange way that I'm hoping someone can help me...

    • FabioRosado: Sadly, this breaks in pyodide.test.ts in a very strange way that I'm hoping someone can help me...

    • JeffersGlass: Thanks @FabioRosado ! For an extra bit of weirdness, if I change that bit of loadInterpreter...

    • JeffersGlass: Ok some further oddities which make me think it's something odd about async interactions between...

    • FabioRosado: That's interesting, the pyodide tests are doing this: ...

    • JeffersGlass: I figured it out! jest is using a mocked version of pyscript.py for the...

    • FabioRosado: Oh dang! That's a great find, awesome work! Copying over seems like a good idea or we could copy...

    • madhur-tandon: @JeffersGlass @FabioRosado Sorry for the late reply. Yeah, I did the mocking thing with an empty...

    • FabioRosado: @JeffersGlass @FabioRosado Sorry for the late reply. Yeah, I did the mocking thing with an empty...

    • JeffersGlass: Maybe we go for the easier path and expand the mocked file Thanks y'all - for now, I've added...

    • madhur-tandon

    • madhur-tandon: Very minor nitpicks, and they probably don't matter but would be nice to have. explicitly match...

      • JeffersGlass: Genuinely very much appreciate these. Thank you!

    • FabioRosado: Apologies a bit late to the party but... NICE! 😄

  • Fix stray capitalization in file name #960 [JeffersGlass]

    It's just not my day for proofreading. The file for version_info had a stay capital "I" in it, breaking links.

    Show Children

    • madhur-tandon

  • Add syntax highlighting #903 [woxtu]

    Hi, This PR adds syntax highlighting to the <py-config> doc.

    Show Children

    • FabioRosado: Hello @woxtu thank you for this!

    • antocuni: Thank you!

    • antocuni: The doc building is failing, maybe it's because it's a PR from a non-maintainer and this it's...

    • madhur-tandon: maybe it's because it's a PR from a non-maintainer and this it's missing some permission? This...

    • madhur-tandon

    • antocuni: @madhur-tandon does this mean that we can merge this PR wihout problems? If so, feel free to...

  • Use `globalThis` #908 [woxtu]

    Hi, This PR changes window and global to globalThis to simplify an implementation. Ref:...

    Show Children

    • FabioRosado: Nice, thank you!

    • antocuni: thank you, it looks much nicer. I'm tagging @tedpatrick since we talked about this recently, so...

    • madhur-tandon

    • tedpatrick

    • tedpatrick: This is good as the globalThis works cross-environment... workers/browser/node equally. We will...

    • antocuni: Cool! Merging it. Thanks @woxtu !

  • Fix a typo #964 [woxtu]

    Hi, This PR fixes a typo in the pyscript doc.

    Show Children

    • FabioRosado: Nice catch thank you!

  • Export Version from JS Module #963 [JeffersGlass]

    Exports the version number as an attribute of the JS module. <script defer ...

    Show Children

    • FabioRosado: Nice thanks! 😄

    • madhur-tandon

    • antocuni: I think that this const should not live in runtime.ts FWIW, it doesn't make sense. Probably the...

      • JeffersGlass: I would agree, though it creates a couple of circular dependencies since so much imports from...

  • Specify the `unknown` type #965 [woxtu]

    Hi, This PR adds the unknown type annotations to resolve some ESLint warnings related to the any type.

    Show Children

    • madhur-tandon: @woxtu Thanks, I am just wondering if any should be used instead. Do you have some thoughts...

    • woxtu: @madhur-tandon I think we should basically use unknown. unknown and any are similar but unknown...

    • madhur-tandon

  • Remove hardcoded cursor for <input> #967 [SpaceCowboy-71]

    As I mentioned in issue #966, this PR fixes that the cursor style is set to 'text' for all input types. This is...

    Show Children

    • FabioRosado: Hello @SpaceCowboy-71 welcome 👋 Thank you for fixing this issue and congratulations on your first PR 😄

  • Restyle examples and add button to show code on all examples #968 [FabioRosado]

    This PR restyles the examples to match pyscript.net, this is how the main page looks like: It also adds a section...

    Show Children

    • antocuni: wow, I love it 😍 I didn't do a proper review because I'm not well versed enough in HTML/CSS to...

    • FabioRosado: Thank you, just pushed a small tweak to css to make the button work on small screens 😄

  • remove deprecated ref in getting started doc #974 [jasonwashburn]

    This PR addresses #973 by editing the Writing into labeled elements example in the getting-started tutorial. It...

    Show Children

    • FabioRosado: Thank you for fixing this!

  • Add three new tutorials and small tweaks to docs #972 [FabioRosado]

    This PR does a few things: Adds a tutorial for [[fetch]] Adds a tutorial for [[runtimes]] Add a 404 error template...

    Show Children

    • JeffersGlass: Nice!

    • JeffersGlass: Technically, it's just that TOML tables have to go after top level keys. So you can...

      • FabioRosado: That's a great point, I just turned the note into a proper note haha Do you think we should...

      • JeffersGlass: What about moving the note to the top (under Example using TOML (default) with something...

      • FabioRosado: that sounds good, thank you so much!

    • JeffersGlass: LGTM! Does make me think we should have some docs for Element though... but that's for another day.

    • FabioRosado: Yeah that's a good point, I'll add it to my queue to start writing something about Element 😄 ...

  • Add tests for changes to examples/ #980 [FabioRosado]

    This PR updates our CI job to run on changes to examples/ as well, initially I was a bit concerned about running the...

    Show Children

    • madhur-tandon: I guess you could just change the comments that state it only runs under pyscriptjs and then we...

    • madhur-tandon: initially I was a bit concerned about running the push to s3, but it seems that s3 sync will...

    • FabioRosado: Yeah, but that part of the CI should still run if we change only the examples right?

    • madhur-tandon: Yeah, but that part of the CI should still run if we change only the examples right? Yup, I...

  • Fix test and add new ones to close 878 #971 [marimeireles]

    Fixed the tests that were xfail or failing + added a new test to make @antocuni happy. Intends to close #878

    Show Children

    • antocuni: Fixed the tests that were xfail or failing + added a new test to make @antocuni happy. Intends...

    • marimeireles: I need to lint it 😅 Alright, of course is to make the code base better but I have to be honest...

    • madhur-tandon: Is this waiting on the CI to pass? If yes, I think #978 fixes it. Maybe @marimeireles we can...

    • marimeireles: Thanks @madhur-tandon will try now! ;)

    • marimeireles: Ah no, I guess it's something else. Will address it now.

    • marimeireles: Okay. I have no idea why this is failing. I don't think it's related to what I'm doing here,...

    • FabioRosado: I'm not sure why but I had to rebase main into my other branch for the tests to pick up the changes

    • marimeireles: Interesting, alright =)

    • marimeireles: Ah, well cause it's running from the previous yamls Makes sense 😅

  • Add error codes to our custom errors #959 [FabioRosado]

    This PR adds error codes and documentation for our custom errors. There is still a few items left to do on the...

    Show Children

    • madhur-tandon: I guess this is carried from a previous mistake but ${to_file} parameter should be "to_file"...

      • FabioRosado: Ah thanks! I'll fix it in the next push 😄

    • madhur-tandon: Why is this imported here?

      • FabioRosado: Oops this was a mistake (I thought I was poking at it on Jeff's branch but seems not 😬 )

    • antocuni: I don't understand: the PR is not marked as WIP nor as draft, but from the first message I seem...

    • FabioRosado: Yeah sorry this is ready for review, I was trying to read the exception docs, but couldn't get it to work

    • marimeireles: I'm +1 :) Thank you for your work here!

    • madhur-tandon: Just curious on the decision for PY2? I have nothing against it but wondering how this was decided 😅

      • FabioRosado: I chose the PY prefix mostly because that's our logo haha then the number after is referred to...

      • madhur-tandon: Aah, thanks, makes sense! Resolving...

    • madhur-tandon: It seems like there is just one Enum while there are 3 ways to access it...

    • FabioRosado: It seems like there is just one Enum while there are 3 ways to access it...

    • madhur-tandon: we can do FetchError.UserError.BAD_THING_D: I guess you meant FetchError.ErrorCode.BAD_THING_D...

    • FabioRosado: we can do FetchError.UserError.BAD_THING_D: I guess you meant FetchError.ErrorCode.BAD_THING_D...

    • madhur-tandon: I guess what I really mean is the following: Currently we do this: throw new...

    • antocuni: so we don't really need ErrorCode to be a property of UserError or FetchError as @FabioRosado...

    • antocuni: Good job, I like it! I don't want this PR to become an endless task. I have marked some comments...

      • antocuni: I love how they match the HTTP error codes :) I wonder whether it makes more sense to move fetch...

        • FabioRosado: That's a good idea! Thanks

      • antocuni: this definitely lacks a docstring :). I love the idea of having a fetch wrapper which does "the...

      • antocuni: [follow-up] Another _createAlertBanner: this is a code smell ;). I think that the correct way to...

        • FabioRosado: That's a good point, I like the both ideas 😄 When I was creating the error codes, I was...

        • antocuni: do you mean HTTP 500? I think that yes, in general we should have a way to inform the user that...

      • antocuni: this seems more a BAD_CONFIG error, not a fetch error (we didn't even try to fetch...

      • antocuni: same as above

      • antocuni: I love how this becomes simpler 😍

      • antocuni: I'm -0.5 to use a catch-all error code for all the features: IMHO each deprecation warning/error...

        • FabioRosado: Right, we talked about that. I'll move deprecated things to the 2 bucket and add some example...

      • antocuni: [follow-up] we need a proper fix for the fake server, eventually :(

        • FabioRosado: Yeah, I chatted with Paul and I think he found a way to deal with this, but I need to look...

    • antocuni: [follow-up] this seems to be related to the comment which I made above about FetchUserError &...

    • antocuni: LGTM, apart the error numbers which seems do be different in the code and in the docs

      • antocuni: Suggested change ...

      • antocuni: the FETCH_* errors doesn't seem to match what's described in the doc, they still use the old...

  • Deprecate pyscript output attribute #981 [FabioRosado]

    This PR deprecates the output attribute in the py-script tag and updates the docs that use it. Closes: #973

    Show Children

    • JeffersGlass: Are these changes duplicated in #982 ? From a casual glance it looks like the output deprecation...

    • FabioRosado: Yes I branched of that other branch since this one would cause a bunch of conflicts haha

    • antocuni: LGTM

      • antocuni: Suggested change ...

        • antocuni: a bit of nitpick, but I think it's good to underline that it's not only deprecated, it's...

  • Use a more precise type #976 [woxtu]

    Hi, This PR changes to use a more precise type instead of the any type. Note: It uses ReturnType<typeof...

    Show Children

    • FabioRosado: Awesome! I was struggling to figure out how to type this in #939

    • FabioRosado: The CI failures don't seem related to this PR so I've kicked another run 😄

    • woxtu: Hmm... 🤔

    • FabioRosado: I just got the same failures on my PR, I'll investigate a bit but its clear that your changes...

    • FabioRosado: Just hit merge as I figured out what happened and opened up a fix for the failing tests 😄

  • Python Plugins #961 [fpliger]

    Goal of this PR is to add support for a very simple [and small] Python Plugins API so that PyScript users can...

    Show Children

    • ntoll: This all makes sense to me. Let's see where this gets us then refine, revise and refactor.

      • ntoll: You can do (in JavaScript, so I think it'll work in TypeScript): p.configure?.(config); Which...

        • antocuni: Also, this might be not needed: you could add empty methods to the Plugin python class, so that...

    • FabioRosado

      • FabioRosado: Funny enough I think this was the reason why my tutorial was failing since I couldn't use...

      • FabioRosado: Since python plugins have the same lifecycle, we should perhaps create a type/interface for...

        • fpliger: Yeah, we could. I didn't want to spend too much time on typing right now because, effectively,...

    • antocuni: I have left many comments, but most are suggestions/discussions which you can decide to...

      • antocuni: [suggestion] I imagine that eventually we want a different/more flexible semantics for...

        • JeffersGlass: I was literally just typing the same thing! At least with regards to the naming. Was also...

        • fpliger: I thought about it but couldn't find a "good" reason why we should create different keys to...

        • antocuni: +1 for having both JS and Python plugins in config.plugins eventually. But my doubts are not...

        • JeffersGlass: I think we agree that if (when! 😄) plugins is an index into a plugin manager or central plugin...

        • fpliger: Not sure I agree. Rather than creating a different key, I'd rather just use plugins and add...

        • antocuni: +1 for experimental.plugins, so that we are free to completely break it when we move to the main section

      • antocuni: at some point you told me that you had to use a timeout to make this working. Did you discover...

        • fpliger: Not really! Very weird tbh

        • antocuni: I think it's related to the other problem we discussed: I start to think that maybe FS.writeFile...

        • fpliger: Yeah, correct. I think that's probably the reason.

        • hoodmane: FS.writeFile is synchronous. The problem is that you need to call importlib.invalidate_caches.

        • hoodmane: At least I hope that's the problem...

        • antocuni: why do you need to call invalidate_caches? If we never tried an import pyscript before, it...

      • antocuni: why do you need to put this in the globals, since it's already available also as...

      • antocuni: +0 on this. At some point we should discuss what is appropriate to import in the global...

        • fpliger: That's why I put the comment above... The intention here is to basically preserve what's in the...

        • antocuni: yes, that why I said +0. I just wanted to warn you about the future disagreements 😂 About...

        • JeffersGlass: Are they passing though? For me, this build fails with set_current_display_target is not a...

      • antocuni: the await is no longer needed, runtime.run is sync now. I'm surprised that typescript doesn't...

        • JeffersGlass: We could add the await-thenable rule to our eslint config, which highlights any time you try...

        • antocuni: +1 for having something which catches it. I don't have any preference w.r.t. how to achieve that...

      • antocuni: I think this is suboptimal: I think that you are downloading all the files sequentially here,...

        • fpliger: Yes. Agree on both things... I'm on a rush right now so I won't change the sequential ->...

      • antocuni: this seems very dangerous. How do you know that e is an actual Error? Also, the try/catch is...

        • fpliger: Honestly, I didn't put too much thought and just copied the code from fetchPaths assuming it was...

      • antocuni: Naming things is hard :). Let me throw some suggestions for names here (feel free to...

        • fpliger: Yeah... it is hard :) So, I've changed: create_custom_element to define_custom_element pyObject...

      • antocuni: [JS question] what are the pros/cons of doing typeof(x) !== 'undefined' vs x !== undefined?

        • hoodmane: x !== undefined raises a ReferenceError if x has not been declared, whereas typeof x !==...

      • antocuni: what happens if the user returns a non-string?

      • antocuni: this seems a spurious comment :)

      • antocuni: this is the actual comment which I mentioned above. Please please please, don't add more global...

        • hoodmane: // this is pseudocode, but ideally I would like to import the module in a private ns, not in the...

        • fpliger: +1 on not adding the app to the global namespace (and things @hoodmane for the hint) and...

        • antocuni: honestly I don't really like the fact that we are looking at module.plugin to find the plugin to...

        • fpliger: Yeah. Let's get it working and discuss that after the dust settles

      • antocuni: Are these console.log for your own debugging, or you plan to leave them? In the typescript code...

        • fpliger: these are for debugging :)

      • antocuni: I don't believe you :). What is the error what you get when it's not "available"?

        • fpliger: For posterity... @antocuni is now a believer lol

        • antocuni: well no, we figured out that the flakyness is inside the JS code and this sleep doesn't help at all

    • hoodmane: You could assign these attributes onto the Pyscript module without mucking with the Python...

    • JeffersGlass: It seems a shame to have to duplicate a lot (but not all) of the functionality that's now build...

      • antocuni: or maybe we could avoid/solve the code duplication by having some common function...

      • fpliger: I'm very -1 on this one. I think this would be a very bad UX from a plugins consumer standpoint....

    • fpliger: Ok, I think it's ready for review. I still had a few things I wanted to fix/change but I think...

    • JeffersGlass: Re: failing tests - This should be from pyodide.ffi import create_proxy - the pyodide API...

    • antocuni: The diff huge. It seems that you have applied some kind of autoformatter which modified code in...

      • antocuni: this should be def define_custom_element, should'nt it?

      • antocuni: -1 for this: it's a warning which is easy to overlook and most importantly it is shown...

        • antocuni: In the meantime, I found out that the mess is even worse that this, see #986

        • fpliger: Meh... I'm -0 because I don't think it's worth the effort and it's not user facing (when user ==...

        • antocuni: Meh... I'm -0 because I don't think it's worth the effort and it's not user facing (when user ==...

      • antocuni: Suggested change ...

      • antocuni: again -1 on this. If it's a warning that the user should see, we should display it on the DOM...

        • fpliger: On this one, we are in strong disagreement here. I'm -100 on raising any warning that is so...

        • antocuni: our users are the developers, and by having "hidden warnings" we don't do a good service to...

    • JeffersGlass: Hi Y'all - minimal time today contribute today, my apologies, but did want to chime in on one of...

    • FabioRosado: Hi Y'all - minimal time today contribute today, my apologies, but did want to chime in on one of...

    • fpliger: @JeffersGlass thanks for the hint on the pyodide API change. TS tests are fixed locally, hope it...

    • FabioRosado: It seems that importing modules is broken in CI, but so far I haven't been able to figure out why 🤔

  • Use response.ok instead of just status 200 #999 [FabioRosado]

    When I wrote the robustFetch I was wondering if we should fail on any code that's not a 200. The fetch API will set...

    Show Children

    • madhur-tandon

  • Added docs for accessing html elements #1002 [adityamali]

    Added documentation about the accessing HTML elements in pyscript using the Element() class.

    Show Children

    • FabioRosado: Hello @adityamali thank you for opening up this PR. We currently have two PRs waiting to be...

  • Rm id use #912 [marimeireles]

    Hello, This is an approach on removing ids. Comments are appreciated! (I was building on top of Antonio's fix, will...

    Show Children

    • marimeireles: Currently, with my changes we have the following behavior with REPL and ids: Thanks to...

    • tedpatrick: There are several ways to find elements in the DOM. // find the item (singular) where...

    • marimeireles: It's a good idea. Thanks @tedpatrick! So that's the current plan? It still doesn't eliminate the...

    • tedpatrick: If we standardize on using attributes other than id, we do not pollute the id namespace at all....

    • marimeireles: Hum, I don't understand what you mean. They're not generating sibling elements as far as I...

    • marimeireles: Testing this code over this snippet of example: <py-script id="first"> display('hello...

    • antocuni: It also feels like the original element should have child elements not generate sibling...

    • FabioRosado: Left a small comment but looks good 😄

      • FabioRosado: This test isn't flaky anymore? Should we remove this line? 😄

        • marimeireles: Yeah, I am supposed to test this today. Obrigada ✨

    • tedpatrick

    • marimeireles: Thanks for the reviews folks!

  • Update docs GitHub actions to deploy to unstable or latest #977 [FabioRosado]

    This PR changes the name of latest to unstable and when we do a release we will push the docs to /<version number>/...

    Show Children

    • JeffersGlass: Just to limit confusion, do we want to rename the workflow file from...

    • FabioRosado: Just to limit confusion, do we want to rename the workflow file from...

    • JeffersGlass: We probably don't need to copy the redirect file on every push to unstable, yeah? It's just...

      • JeffersGlass: Either way, going to approve this so it can be merged at your leisure - it is sorely needed....

      • FabioRosado: Yeah probably not, both actions have this line so I'll remove it 😄

    • JeffersGlass

    • antocuni: I know it's commented out but this is a typo, might cause problems if someone blindly tries to...

      • FabioRosado: If we remove the folder the s3 sync command will recreate it, the only issue is that we would...

  • Fix failing integration tests #978 [FabioRosado]

    Tests in main have been failing since #968 was merged, this PR fixes the failing tests. Looking into it, it seems...

    Show Children

    • madhur-tandon: Great find @FabioRosado One question I have is -- Does the CI still run on changes to...

    • madhur-tandon

    • FabioRosado: Thanks! I doesn't because I wasn't sure if we wanted to change CI, but from the discord I think...

    • antocuni: uhm... I wonder whether we could/should detect the "double include" case and emit a clean error...

      • FabioRosado: yeah I think that's a good idea, I was seeing some weird behaviour on the splash screen saying...

  • Remove comments from github actions #1011 [FabioRosado]

    Following Antonio's suggestion, this PR removes commented out code from our github actions to avoid us uncomment...

    Show Children

    • marimeireles: Makes sense to me thanks 👍

    • FabioRosado: Obrigado! 😄

  • Invalidate cache on FS writes #996 [JeffersGlass]

    Following the merge of #961, there have been intermittent issues with loading modules via [[fetch]] and the plugin...

    Show Children

    • FabioRosado: This looks good thank you for working on this. I wonder, since we are using the same code to...

    • madhur-tandon: Looks good, I am just wondering if one should use runtime.run instead of runtime.interpreter.runPython?

    • hoodmane: I would still suggest for Pyodide: Suggested change ...

    • JeffersGlass: Thanks for all the comments! Invalidating the import path cache is now factored out into...

    • madhur-tandon

    • tedpatrick: 🚢

    • fpliger: Great PR!! Thank you @JeffersGlass 🚀

      • fpliger: I think this is unnecessary because you are already calling...

    • antocuni: Leaving this comment for posterity: it seems very likely that the root cause was this...

  • remove unneeded imports #991 [madhur-tandon] sprint

    Show Children

    • ntoll: Tests failing. :-(

    • madhur-tandon: Tests failing. now they pass, it was unrelated, now fixed by Jeff!

    • FabioRosado

  • WIP: Fix antigravity #1016 [JeffersGlass]

    This PR fixes an issue in the Antigravity example that has appeared since the 2022.09.1 release, due to changes in...

  • Improve UX when we can't install a package #1000 [FabioRosado]

    Currently when we try to install a package that does not exist or there are no pure wheels for, things fail silently...

    Show Children

    • madhur-tandon: nitpick but try{ --> try {

    • madhur-tandon: I think this comment shouldn't be there

    • madhur-tandon: same here, comment shouldn't be present

    • madhur-tandon: Minor suggestions but looks good! Do we want to perhaps show the traceback in a clickable...

    • FabioRosado: Thanks just pushed the changes and also added docs for the error in the console can you check if...

    • antocuni: LGTM, I like it :). Also, I think that this should also speed up the loading time of all the...

      • antocuni: here we should check that e is actually a Python error and not some unrelated exception that we...

        • FabioRosado: In that case we are adding the exception message to the banner. Would that be enough you...

        • antocuni: In that case we are adding the exception message to the banner. Would that be enough you...

  • Rm MIME types that we don't offer support to #1013 [marimeireles]

    Show Children

    • JeffersGlass: LGTM!

    • marimeireles: Vielen Dank! :)

  • Fix clashing test names #1018 [madhur-tandon] sprint

    Although the issue #995 was closed by @FabioRosado's PR #998 This PR just follows @antocuni's advice on renaming of...

    Show Children

    • FabioRosado: Thanks, forgot to remove the "fixes" from the PR body

  • Convert image bytes to base64 in pyscript's render_image #1020 [FabioRosado]

    This PR adds logic to render_image to convert bytes into base64. Based on the user's issue, it seems that we need to...

    Show Children

    • madhur-tandon: Haha, I was gonna submit a PR for this too, you beat me to it xD

    • madhur-tandon: I just think that this test should be in test_02_display.py

    • madhur-tandon: Maybe a regex check as shown here:...

    • FabioRosado: Thanks! Just moved the test and added a regex checker 😄

  • version injection #952 [tedpatrick]

    Add package.json version into main.version to be used elsewhere in out version API

  • WIP: kill <py-register-widget> and introduce `<py-plugin>` #642 [antocuni]

    This is a first draft of a <py-plugin> component. It is more a proof of concept than a real PR, but I think it's...

    Show Children

    • tedpatrick: Thank you for your PR contribution to PyScript. We are closing PRs older than 90 days with...

  • Fake server 404 support #994 [tedpatrick]

    Return a 404 when a file does not exist in local disk

    Show Children

    • madhur-tandon: LGTM!

    • antocuni: LGTM but: it's missing a test; probably something along these lines in test_support.html: ...

    • tedpatrick: Added tests, and updated 404 errors to suit.

    • madhur-tandon: Probably late but this error message and the one below it are extremely similar. I guess we can...

      • madhur-tandon: cc: @tedpatrick

  • Fix antigravity #1017 [JeffersGlass]

    This PR fixes an issue with the antigravity example, which had started sometime since the 2022.09.1 release, and...

    Show Children

    • tedpatrick

    • madhur-tandon

  • Rewrite the get started tutorial using the ice cream demo #985 [FabioRosado]

    Our get started tutorial is more of a guide of all the things one can use in PyScript, following the diataxis model,...

    Show Children

    • antocuni: Having an easier tutorial and don't mix it with reference docs sounds like a good idea to me. I...

      • antocuni: I would suggest swap the two links, since TOML is the default format and JSON is the "secondary"

      • antocuni: Suggested change ...

      • antocuni: this is not strictly correct. With <py-config> you install libraries, but you don't import...

      • antocuni: this is also a bit unclear. The only effect of having text inside <py-repl> is to pre-populate...

        • FabioRosado: I changed it to something like: "Note that we are adding ice_data to py-repl to pre-populate the...

      • antocuni: maybe we can use a better name for this?

    • Cheukting: I am glad that you like the ice cream demo. Originally I planned to use it in Chapter 2 of my...

    • FabioRosado: I am glad that you like the ice cream demo. Originally I planned to use it in Chapter 2 of my...

    • marimeireles: I think this might be ready to merge, if @antocuni agrees.

    • FabioRosado: I think this might be ready to merge, if @antocuni agrees. I think so, just waiting on a green tick 😄

    • marimeireles

    • FabioRosado: Obrigado!

    • madhur-tandon: this should be than only @FabioRosado 😅

  • split py-config into sections #1022 [madhur-tandon] sprint

    This changes a few things that @FabioRosado's PR does in #982, although they are very minor. Fetch section updated...

    Show Children

    • marimeireles: LGTM

  • Update docs examples so they don't use deprecated features, styling tweaks #982 [FabioRosado]

    This PR updates any example from our docs that was using deprecated features or in some cases it was using ways to...

    Show Children

    • JeffersGlass: Very nice! Not approving since I’m on mobile and don’t have the ability to actually build and...

    • FabioRosado: Am I misremembering that in js pyscript.globals used to be a reference for...

    • JeffersGlass: When I was doing the original js module export (in rollup config), I know I waffled between...

    • antocuni: When I was testing things I got a PyScript is not defined but pyscript is. So I thought it was...

    • fpliger: Great call @FabioRosado

    • madhur-tandon: is this supposed to be Pyodide.http.pyfetch or pyodide.http.pyfetch?

      • FabioRosado: should be lowercased, fixed thanks 😄

    • madhur-tandon: this should be set to true since we are showing an equivalence between TOML and JSON here

      • madhur-tandon: and in the TOML based example which precedes this, we use true

      • madhur-tandon: also fixed in #1022 though

    • madhur-tandon: I have modified the headings / examples subsection a bit in #1022

    • FabioRosado: Thanks @madhur-tandon since your PR addresses some of your comments, should we merge this in and...

    • madhur-tandon: Should we merge this in and then merge yours after to address those things? Yes, I think yours...

    • madhur-tandon

  • updated docs for fetch #1019 [madhur-tandon] sprint

    Inspired by @JeffersGlass Closes #1007

    Show Children

    • madhur-tandon: Should probably be merged after @FabioRosado's #982

    • marimeireles: Thanks for the work here!

      • marimeireles: Since this is so inspired by Jeff's work how about adding a link to his website: "Learn more...

        • madhur-tandon: The blog is in draft mode right now and isn't published yet.

        • madhur-tandon: So maybe we shouldn't link it right now, what say @marimeireles CC: @JeffersGlass -- unless you...

        • JeffersGlass: Missed this until a bit late - the production URL will be...

        • madhur-tandon: Thanks, done in #1024

    • FabioRosado

  • add reference to Jeff's blog #1024 [madhur-tandon] sprint

    Show Children

    • JeffersGlass: Would help if I didn't typo on my own URL huh? 😅 Should be:...

      • madhur-tandon: haha, okay let me fix

    • JeffersGlass: LGTM!

  • Fix for D3 and 3JS demos #1025 [tedpatrick]

    Fix for D3 and 3JS demos

    Show Children

    • FabioRosado: Thank you for the quick fixes! The issue with importmap not working is it a regression? 🤔

  • Introduce DeprecatedGlobal and show proper warnings #1014 [antocuni]

    This PR fixes #986. In particular: remove the from pyscript import * into the globals. Instead, import only few...

    Show Children

    • JeffersGlass

      • JeffersGlass: I'd suggest adding MIME_METHODS and MIME_RENDERERS to this list - in previous discussions, some...

        • antocuni: in previous discussions, some users have been routed to look at these attributes ouch, I wasn't...

        • antocuni: I correct myself, I found a way to support MIME_METHODS and MIME_RENDERERS easily. Fixed by ef80b7b

        • JeffersGlass: Very nice!

      • JeffersGlass: Do we need/want to import the js module here? I know it's one of the modules imported 'by...

        • antocuni: This is a valid point. We don't even need to make it a DeprecatedGlobal because it was not...

        • fpliger: commenting for posterity since we merged this already... I'm fine to leave this as is, sit down...

      • JeffersGlass: See note in main.ts about the js module.

      • JeffersGlass: Thanks for the cleanup! LGTM.

      • JeffersGlass: Agreed about killing them eventually.

    • FabioRosado: Nice! Thank you for cleanup this, I really like the assert no banners check! 😄

    • antocuni: @FabioRosado in commit 376911d I merged your changes from #1000 into this PR. However, this line...

    • antocuni: Ah, it also causes jest tests to fail 😤 (I assume because they are compiled in a stricter mode...

    • FabioRosado: @FabioRosado in commit 376911d I merged your changes from #1000 into this PR. However, this line...

    • FabioRosado: Actually, looking into the pyodide typing, I think this is happening because pyimport() returns...

    • madhur-tandon: why not use the deprecate method here? just like others. I mean, why use ns[name] =...

      • antocuni: because I wanted to use a completely different message

      • madhur-tandon: Yeah, but then, that message can simply be passed as one of the parameters to the deprecate function.

      • madhur-tandon: As far as I recall, the deprecate function already expects the message as its argument. So even...

      • madhur-tandon: I think I got what you meant, this is because the message is about private implementation and...

      • madhur-tandon: Resolving this, but leaving the other one open.

    • madhur-tandon: similarly here, we can use the deprecate method instead.

      • antocuni: same answer as above :)

      • madhur-tandon: And here, I guess the message is not different after all since it's not about private implementation.

    • antocuni: Extending the Micropip interface with pyproxy seems to fix the warning and the test...

    • FabioRosado: does this actually check that the returned object implements the interface, or it just assumes...

    • tedpatrick

  • Add Element to the API reference #998 [FabioRosado]

    This PR adds an API reference section for the Element API. It shows all the methods available and examples of how to...

    Show Children

    • fpliger: This is GREAT! I've always been a bit meh about adding docs about the Element API because I...

    • antocuni: This is GREAT! I've always been a bit meh about adding docs about the Element API because I...

    • marimeireles: This is really good work! Thank you Fabio =) I left a few comments, please feel free to...

      • marimeireles: We're deprecating Element.write pyscript/pyscriptjs/src/python/pyscript.py ...

        • FabioRosado: Just to confirm, he thing that we are deprecating is pyscript.write not element.write right? 🤔

        • marimeireles: Ohh that's true! Sorry. Even though pyscript.write is only calling element.write I think we want...

        • marimeireles: So that's an invalid comment, thanks for noticing.

        • FabioRosado: ah gotcha, i was just wondering if I missed something on discord 😄

      • marimeireles: Maybe we should be specific here and say which mimes we're rendering? I made a list with the...

      • marimeireles: We can be more specific about query coming from querySelector we can link for MDN here.

      • marimeireles: Maybe here is worth mentioning what kind of child, I think it's a div

      • marimeireles: Again, I think we should specify that this is essentialy a wrapper on the JS function, as I said earlier.

      • marimeireles: The code still contains some pieces that are just dead code. It seems like this can be safely...

      • marimeireles: Just a comment on the name of the file, according to discussions on #995 we decided to remove...

    • FabioRosado: Thanks! Pushed a new commit to address your comments Mariana. Also the el.content seems to exist...

    • marimeireles: Hey @FabioRosado well, I guess you're right, it's used in here, right? ...

    • marimeireles: Seems good to me! :) Thanks Fabio. I wonder why the docs are failing? Is this normal? edit: Ah...

    • FabioRosado: Hey @FabioRosado well, I guess you're right, it's used in here, right? ...

    • fpliger: I personally don't think it makes a lot of sense honestly since users could just do...

    • marimeireles: The question was: should we remove el.content because users can have access to it using...

    • marimeireles: @fpliger ^ sorry, forgot to mark you.

    • fpliger: Honestly, I'm indifferent on this one because I really hope we kill it sooner but if it was an...

  • add docstrings for loadFromFile #997 [madhur-tandon] sprint

    cc: @fpliger

    Show Children

    • FabioRosado: Thanks! Small comment but is more of a question haha

      • FabioRosado: Do you think it makes sense adding an example in the format: await...

        • madhur-tandon: Thanks, added!

    • fpliger: This reads a bit confusing to me. A good best practice is to start with a good summary sentence...

      • madhur-tandon: Thanks, changed a bit!

    • fpliger: Similarly to the comment above, I think this over complicates the message.... As a reader, I...

      • madhur-tandon: I wanted to give a detailed example, but I can make it shorter of course 😅

      • madhur-tandon: Done, although the approach is iterative here and not recursive.

    • fpliger: I think it's fine to keep this part

    • fpliger: What about folders? Can I pass a path like a/b/c and expect the file to be written as...

      • madhur-tandon: Thanks, I highlighted this in a NOTE at the end. a/b/c is not valid basically, we need a full...

    • fpliger: Can you also add comments? As a consumer of the code, I'd like a comment that saw: what does...

      • madhur-tandon: done

    • fpliger: Left a few comments... think some of them should be addressed before we merge

    • madhur-tandon: some of them should be addressed before we merge Done all, should be ready I guess

    • fpliger: Overall lgtm, thank you @madhur-tandon !

    • antocuni: I'm too late in the conversation, but at some point we should rename this function. It's not...

    • antocuni: I'm too late in the conversation, but at some point we should rename this function: It's not...

    • fpliger: Great point. +1 on fetchAndSave

  • Remove freedom units from examples #1026 [FabioRosado]

    This PR removes the toga example from the examples list. Looking at the code it seems that we have two things...

    Show Children

    • madhur-tandon: Okay, we can remove it, but should we close the corresponding issue? #1009

    • FabioRosado: Not sure I would like to spend some more time looking at the failure and then close or fix the issue 😄

  • fetch early, write later to emscripten's FS #992 [madhur-tandon] sprint

    Owing to the discussions here: pyodide/pyodide#3274 and inspired by @ntoll's work here:...

    Show Children

    • madhur-tandon: @FabioRosado I am wondering if you could help with the issue regarding eslint / type related stuff.

    • FabioRosado: This is the line that eslint is complaining about. It complains because you are passing the...

      • madhur-tandon: Aah thanks, I thought the declaration had an issue. Might have missed the line number. In any...

    • FabioRosado: Just left some comments and nothing that would block the PR to be merged so approving. Also,...

      • FabioRosado: We can probably remove this comment since we aren't using loadFromFile anymore and fetching...

      • FabioRosado: Just tested both and seems like we can use robustFetch here as well, might be a good idea to use...

      • FabioRosado: Since the robustFetch handles any non 200 status code, this logic will always return true...

        • antocuni: I'm not an expert of async code but this looks like an anti pattern to me. The proper pattern...

      • FabioRosado: This seems a duplication of the above logic, what do you think about creating a helper method for it? 🤔

      • FabioRosado: I was looking for this or a similar thing when debugging CI today so thanks 😄 👍

    • FabioRosado: Oh btw locally the plugins tests are failing, but not in CI so 🤷

    • antocuni: Sorry but I'm -1 on using this approach. If we need to "wait for the runtime to be ready", we...

      • antocuni: why not a for loop?

    • madhur-tandon: I am closing this PR and will probably try again / open another one.

  • patch plt.show() and use AGG beneath #1023 [madhur-tandon] sprint

    This is kinda WIP and may require improvements But showcases how things like #983 can be fixed. Add Tests Add Comments

    Show Children

    • FabioRosado: Left a comment and a suggestion. Is this a hard thing to patch upstream? Just wondering if it...

      • FabioRosado: I'm slightly concerned about installing matplotlib all the time even if we don't need it. What...

      • FabioRosado: Perhaps we could do something like: from contextlib import suppress with...

    • madhur-tandon: Hi @FabioRosado As I said, this is kinda WIP right now, but fixes the issue hehe. I think there...

    • FabioRosado: Ah apologies, I just looked at the title and didn't read the main PR text

    • madhur-tandon: Closing, since we don't really need this. The solution to the original issue is using display...

  • Fix the toga example #1028 [FabioRosado]

    This PR fixes the toga example by: Updating the wheels to the latest available Small tweaks to make things work...

    Show Children

    • JeffersGlass: Personally I have mixed feelings... on the one hand, it's neat to show that there may be ways to...

    • FabioRosado: Great, I have removed it from the examples page in a previous PR 😄

    • madhur-tandon: Seems like this was already removed in #1026 Why is this diff re-appearing?

      • FabioRosado: I branched off #1026 but github shouldn't pick it up since it got merged 🤔

    • madhur-tandon

  • Release 2022.12.1.RC1 #1030 [tedpatrick]

    PR changing the final version number for 2022.12.1.RC1

    Show Children

    • FabioRosado: 🚢 -- edit -- Wow that's a very tiny boat haha

    • tedpatrick: Going to do an RC1

  • add docs for using display with matplotlib #1029 [madhur-tandon] sprint

    addressed #983 due to lack of docs

    Show Children

    • tedpatrick

    • FabioRosado: I think this may be too specific to matplotlib, perhaps the best place to put this is as a...

    • tedpatrick: 🚢

  • Bump bokeh, panel versions #1032 [JeffersGlass]

    This bumps the version of panel from 13.1 to 14.1, to avoid showing a deprecation warning for the use of...

    Show Children

    • madhur-tandon: LGTM!

  • Fix py-markdown plugin #1008 [fpliger]

    Unescape the tag content before actually running markdown and actually explicitly import console since we now are...

    Show Children

    • FabioRosado: Small comment to fix lint 😄

      • FabioRosado: Since we are importing console on line 4, should we remove it from here? ...

    • antocuni: this seems to be missing a test

  • remove fetching of pyscript.py from tutorial #1036 [madhur-tandon] sprint

    Fixes #1035

    Show Children

    • JeffersGlass: LGTM!

  • [WIP] examples inspector plugin #1040 [fpliger]

    Close #1039

  • Fixing docs Issue #1033 #1037 [IanoNjuguna]

    Issue: #1033 Created by @fpliger Assigned by @madhur-tandon What I did I moved the info in /pyscriptjs/README.md to...

    Show Children

    • IanoNjuguna: Hello @FabioRosado I'm a first time contributor. How can I resolve the failed checks?

    • madhur-tandon: @IanoNjuguna checks on docs are expected to fail because of the issue encountered in configuring...

    • FabioRosado: Hello @IanoNjuguna thank you for working on this issue! I think this section would fit nicely...

      • FabioRosado: I know this was in the README, but I think this should be expanded to include these other...

  • getPySrc should return source code #1041 [madhur-tandon] sprint

    Fixes #1038 TODO: Add Test Fix dynamic tag text

    Show Children

    • FabioRosado: Left some comments, let me know what you think 😄

      • FabioRosado: This could become Suggested change ...

        • madhur-tandon: Yeah, so, there is a subtle difference. If you notice the first commit of this PR, I do it...

        • FabioRosado: I see that makes sense thanks!

      • FabioRosado: Small nit: what you think of this name change? Suggested change ...

        • madhur-tandon: Yeah, thanks, changed.

      • FabioRosado: Nice trick!

        • madhur-tandon: Thanks 😅

    • FabioRosado

    • fpliger: LGTM! TY @madhur-tandon 🚀

  Issues

  Earliest to Most-Recent

  • Release Testing 2022.09.1 - RC2 #798 [tedpatrick]

    We are feature complete for a release of PyScript this week. We need your help testing 2022.09.1. How to test...

    Show Children

    • madhur-tandon: Closing this since we released it 🚀

  • Logging seems overly verbose in 2022.09.1.RC2 #799 [tedpatrick] type: bug needs-triage

    Checklist I added a descriptive title I searched for other issues and couldn't find a solution or duplication I...

    Show Children

    • madhur-tandon: Should we close this now @tedpatrick?

    • tedpatrick: Closed by #809

  • Problems with modules #462 [nouseramefounded]

    I can't import modules as os, subprocess and so on...some solution?

    Show Children

    • Kali95739: Yes you can with node lol

  • Malformed TOML causes browser hang #812 [pauleveritt] type: bug needs-triage

    Checklist I added a descriptive title I searched for other issues and couldn't find a solution or duplication I...

    Show Children

    • madhur-tandon: Seems like the TOML parser doesn't error out and hangs instead. CC: @tedpatrick

    • madhur-tandon: Looking in #813, still in discovery phase though

    • tedpatrick: Valid. Looks like rollup packaging mangled the errors coming out of TOML lib.

  • [BUG] Error: Pyscript not loading when RequireJS is included on the page #317 [SlendyBoy] type: bug waiting on reporter tag: pyodide lang: typescript backlog

    Hello, I'm coding an activity module on Moodle. This module will allow the analysis of quiz data from Moodle...

  • Add SRI to hotlinking examples #326 [mflaxman] type: enhancement backlog

    Given the security implications of pyscript, it makes sense to recommend SRI when hotlinking pyscript.js: <script ...

  • how to run offline #330 [michavardy] tag: tooling

    Pyscript I have cloned the repo, I have run npm install in the correct directory I have run npm run dev and then I...

    Show Children

    • marimeireles: Closing because we figured out this is a new issue. We already have an issue to track that we...

  • embed openRefine #331 [michavardy] type: enhancement backlog

    Hey pyscript, at work we use Open-Refine: https://openrefine.org OpenRefine is an open-source desktop application...

    Show Children

    • marimeireles: I wonder if this discussion goes in the direction of what Dominik is tackling here? #595 (comment)

  • Directory recognition problem #338 [hygorrasec] needs-triage

    Hello guys, I'm not sure if it's a mistake or if I'm doing something wrong. Can anybody help me? The function below...

    Show Children

    • marimeireles: We're soon going to have amazing docs on it! Keep an eye on the work that Domink is doing #595...

  • [DISCUSSION] Dynamic loading style (CSS) and theming support #340 [fpliger] type: enhancement tag: styling ideas lang: typescript backlog

    PyScript currently "requires" users to load the CSS explicitly and separately from the JS. This has a few...

  • [BUG] Demo pages not (fully) loading #342 [oaustegard] needs-triage

    Describe the bug The Demo pages at https://pyscript.net/examples/ partially load but eventually time out waiting for...

  • [BUG] Special characters #344 [kPlusPlus] type: bug backlog

    Describe the bug How to prints special characters and html tags ? print("<b>Hello Mihael</b>") print("<h1>Hello...

  • Activate the `Discussions` tab from repository settings #348 [sugatoray]

    Please activate the discussions tab so questions, announcements, and anything that is strictly not an issue...

    Show Children

    • marimeireles: Yes, I think this is a close for now... We're still using the discourse as a community...

    • sugatoray: @marimeireles Sounds good. Thank you. Will send a PR.

  • [BUG] pyparsing version in py-env tag is ignored #343 [ptmcg] tag: pyodide

    Describe the bug Adding this entry in the py-env tag does not get the desired version of pyparsing: -...

    Show Children

    • marimeireles: This will soon be outdated by #775, I believe.

  • [FEATURE] Stubs for python language server #361 [John-Schreiber] type: enhancement backlog

    It would be useful to have stubs for the pyodide and js modules so syntax highlighting and autocorrect work. Pyodide...

    Show Children

    • marimeireles: It would! Interesting thing to tackle. :)

  • [FEATURE]need document on use external python package #369 [retsyo] needs-triage backlog

    I have a python installation with kinds of package in, for example, e:\prg\py, yes I am on Windows OS. On the other...

  • [FEATURE] Disable default styling in CSS #375 [AstragoDE] tag: styling backlog

    Is your feature request related to a problem? Please describe. Currently, the imported CSS is applying default...

    Show Children

    • marimeireles: Yes, this will be modular in the future. But it's work that has to be done. Thanks for opening...

  • [BUG] Importing JS from a local webserver fails #379 [tildebyte] type: bug backlog

    Describe the bug Importing JS from a local webserver fails with pyscript active. I'm using relative URLs here; I...

  • [BUG] #380 [SupJoN] waiting on reporter

    sometimes it can not run turn

  • [FEATURE] Add simple guidance to your "[BUG]" issue template to highlight basic limitations #382 [nmstoker] ideas backlog

    Is your feature request related to a problem? Please describe. PyScript is creating a lot of enthusiasm (rightly so...

    Show Children

    • marimeireles: Seems like this was resolved. Thanks for the input @nmstoker!

  • [FEATURE] Is it possible to get more verbose package failure when installing with micropip in the repl? #385 [canyon289] needs-triage backlog

    Is your feature request related to a problem? Please describe. I'll use ArviZ for this example so we can make it...

  • [FEATURE]Possible to use Pytube in Pyscript? #386 [dominicdev] waiting on reporter

    Is your feature request related to a problem? Please describe. I'm trying to get info from different type of youtube...

  • [FEATURE] Provide better Error messages, with a priority on REPLs #404 [yannickfunk] type: enhancement tag: repl tag: rendering backlog

    Is your feature request related to a problem? Please describe. Currently, when running invalid code in a REPL, the...

  • [FEATURE] Insert a py-repl with multi-line code inside (using ideally JS) #406 [ckavidas] type: enhancement backlog

    Is your feature request related to a problem? Please describe. I would like to be able to insert a py-repl element...

  • [FEATURE] pyscript and TiddlyWIki #409 [AnthonyMuscio] tag: example backlog

    Is your feature request related to a problem? Please describe. I do not know pyscript even python, but I am a...

  • [FEATURE] REPL auto-generate functionality enhancement #412 [chekoduadarsh] waiting on reporter

    Is your feature request related to a problem? Please describe. This issue is an extenction of PR #354 and Issue #188...

    Show Children

    • marimeireles: I don't understand this issue. Can you please explain it further? Thank you!

    • marimeireles: Maybe it's resolved already?

  • Add syntax highlighting for Python + HTML in SublimeText #419 [marimeireles] tag: environment backlog

    It'd be awesome to set up double syntax highlighting for Sublime text: Python + HTML in the same file. It seems like...

  • [DOCS] Korean translation #444 [weensy] tag: docs backlog

    I am ready to translate the docs into Korean. 🇰🇷 I saw the PR of the Japanese translation. If that PR is merged, I...

  • Neural networks doesn't function in pyscript #475 [taranis2025] tag: pyodide waiting on feedback type: support

    Checklist I added a descriptive title I searched for other issues and couldn't find a solution or duplication I...

    Show Children

    • marimeireles: I'm not sure if we should close this as a no-fix... because it's probably really low in our...

  • multiprocessing module not working as expected - _multiprocessing missing (not supported?!) #476 [pawelgnatowski] type: bug tag: pyodide backlog

    Checklist I added a descriptive title I searched for other issues and couldn't find a solution or duplication I...

  • Panel streaming demo example is buggy but works #484 [marimeireles] type: bug plat: chrome plat: firefox tag: example

    Checklist I added a descriptive title I searched for other issues and couldn't find a solution or duplication I...

    Show Children

    • marimeireles: Not relevant anymore. Works again.

  • Must run script twice for expected result to happen #491 [imbev] type: bug needs-triage

    Checklist I added a descriptive title I searched for other issues and couldn't find a solution or duplication I...

    Show Children

    • marimeireles: Thank you @JeffersGlass !

  • Default REPL `indentUnit` to 4 #531 [HighDiceRoller] type: enhancement

    Checklist I added a descriptive title I searched for other issues and couldn't find a duplication I already...

  • trouble happen when using npm to install pyscript on Windows #493 [erjiaxiao] tag: tooling lang: typescript

    Checklist I added a descriptive title I searched for other issues and couldn't find a solution or duplication I...

    Show Children

    • marimeireles: I believe the warning was fixed? :) If not feel free to re-open it. Cheers, folks.

  • add examples to home page to show what cool things PyScript is capable of [FEATURE] #352 [pgbovine] needs-triage

    Is your feature request related to a problem? Please describe. As a first-time visitor to the PyScript home page, I...

    Show Children

    • marimeireles: This is a work in progress in the github.com/pyscript/pyscript-collective/ repository. You can...

  • [FEATURE]write browser extensions/plugins with pyscript #350 [andrewchenshx] type: enhancement backlog

    As a python programmer, i hope i could write browser extensions/plugins with pyscript. thanks

    Show Children

    • marimeireles: I'm not sure this is an actual issue though. Do we have any actual problems here? Feel free to...

  • Improving PyScript docs #579 [marimeireles] tag: docs backlog epic

    This is an umbrella issue to coordinate documentation efforts. When adding new pieces of documentation keep in mind...

  • Add PyScript syntax (tags, etc) to the "Reference" session of the docs #582 [marimeireles] tag: docs

    In my opinion this part of the Getting started file onward should be in the Reference session, or am I misreading it?

    Show Children

    • marimeireles: Tracked somewhere else.

  • Add documentation on the actions that our `Makefile` is capable of #580 [marimeireles] tag: docs backlog

  • Create a new API/feature for uploading files to PyScript #558 [andreaslam] type: enhancement backlog

    Checklist I added a descriptive title I searched for other feature requests and couldn't find a duplicate...

  • Create versioning and release process announcement #544 [fpliger] tag: docs backlog

    Checklist I added a descriptive title I searched for other issues and couldn't find a duplication I already...

  • New Line Character not working in pyscript.write's string #540 [thenithinbalaji] type: bug backlog

    Checklist I added a descriptive title I searched for other issues and couldn't find a solution or duplication I...

  • Console printing is not rended on the page if there is an expensive process running #529 [adilaxmdv] type: enhancement backlog

    Checklist I added a descriptive title I searched for other issues and couldn't find a solution or duplication I...

  • When PyScript fails to load, it should tell the user #527 [metaperl] type: enhancement ideas backlog

    Checklist I added a descriptive title I searched for other feature requests and couldn't find a duplicate...

  • pyscript doesn't works in linux 32 bit browsers. #496 [Vaib215] type: bug needs-triage

    Checklist I added a descriptive title I searched for other issues and couldn't find a solution or duplication I...

    Show Children

    • marimeireles: Closing due to inactivity, please feel free to re-open!

  • visual-automata library does not work, same goes for colormath. it says - Couldn't find a pure Python 3 wheel for 'colormath' #498 [TG721] type: bug needs-triage backlog

    Checklist I added a descriptive title I searched for other issues and couldn't find a solution or duplication I...

  • PyScript REPL + WASM Integration #499 [nyckmaia] type: enhancement needs-triage backlog

    Checklist I added a descriptive title I searched for other feature requests and couldn't find a duplicate...

  • Allow Users to Override stdin when loading Pyodide #502 [JeffersGlass] type: enhancement needs-triage backlog

    Checklist I added a descriptive title I searched for other feature requests and couldn't find a duplicate...

  • Add prettier or some other JS formatted to pre-commit #505 [fpliger] type: enhancement good first issue lang: typescript

    Checklist I added a descriptive title I searched for other feature requests and couldn't find a duplicate...

    Show Children

    • marimeireles: Closing as solved :)

  • [DOCS] Indonesian Documentation #508 [naschimhit] tag: docs backlog

    Do I need to translate read.md into Indonesian? I think it's not necessary. If you think it's necessary, let's...

    Show Children

    • marimeireles: Wow! This is so awesome! I'm looking so forward for this. We need to set up a system, but it'd...

  • Bug (maybe Security related) #509 [Network-Sec] type: bug waiting on reporter

    Checklist I added a descriptive title I searched for other issues and couldn't find a solution or duplication I...

    Show Children

    • marimeireles: Closing as inactive. Feel free to re-open if you still think we have an issue here. Thanks for the input.

  • Bug: setting runtime configuration to local pyodide.js occurs an exception #515 [TutorExilius] type: bug needs-triage

    Checklist I added a descriptive title I searched for other issues and couldn't find a solution or duplication I...

    Show Children

    • marimeireles: I think if it was working fine with the alpha release we can safely close it? Please feel free...

  • telnetlib connection #524 [iAmJamesGardner] tag: pyodide backlog

    Checklist I added a descriptive title I searched for other issues and couldn't find a solution or duplication I...

  • Support ANSI Escape Codes with print() #596 [mkunz7] type: enhancement backlog

    Checklist I added a descriptive title I searched for other feature requests and couldn't find a duplicate...

  • Improve documentation on how to handle binary and non-binary files (local/remote, up-/download) #595 [do-me] tag: docs backlog

    Checklist I added a descriptive title I searched for other issues and couldn't find a duplication I already...

    Show Children

    • do-me: I finally found the time for testing binary downloads from the virtual file system. I wrote a...

  • Using pygame in pyscript #592 [Python-Ninja-Hebi] waiting on reporter

    Checklist I added a descriptive title I searched for other issues and couldn't find a duplication I already...

    Show Children

    • marimeireles: Oh cool, so that means that the 3.11 is working? This is good news for @ntoll Thanks for letting...

  • Save the content of your page into an app #587 [marimeireles] type: enhancement needs-triage backlog

    Checklist I added a descriptive title I searched for other feature requests and couldn't find a duplicate...

  • Add how to deploy PyScript to the "Deployment" session of the docs #584 [marimeireles] tag: docs backlog

  • How to load different files and manage your environment on the "How to session" #583 [marimeireles] tag: docs backlog

    Create a how to session on environment management. I see that a common question that arises between newbies is that...

    Show Children

    • marimeireles: Being worked on by @do-me here: #595 (comment)

  • Serve pyscript with Access-Control-Allow-Origin header #805 [joemarshall] type: enhancement needs-triage backlog

    Checklist I added a descriptive title I searched for other feature requests and couldn't find a duplicate...

  • Not All Browser Events are Represented in py-on* Events #801 [JeffersGlass] type: bug good first issue backlog

    Checklist I added a descriptive title I searched for other issues and couldn't find a solution or duplication I...

  • A few different MIME types don't work #767 [marimeireles] type: bug backlog

    Checklist I added a descriptive title I searched for other issues and couldn't find a solution or duplication I...

  • <py-script>, <py-button> and <py-inputbox> etc. are executed in a non-obvious order #761 [antocuni] backlog

    Currently there are three tags which allow to execute python code: <py-script>, <py-button> and <py-inputbox>, but...

  • pyscript is incompatible with frameworks using hydration #746 [fcrozatier] type: bug backlog

    Checklist I added a descriptive title I searched for other issues and couldn't find a solution or duplication I...

  • Website and README should discuss versioning scheme #683 [philippjfr] duplicate tag: docs

    In this blog post we announced the versioning scheme for PyScript going forward which includes alpha, latest,...

    Show Children

    • marimeireles: This is a dup! Thank you @philippjfr.

  • PyScript npm module? #675 [echarles] type: enhancement backlog needs-work

    Checklist I added a descriptive title I searched for other issues and couldn't find a duplication I already...

  • Higher Level Python API Design #659 [fpliger] type: enhancement lang: python backlog

    Checklist I added a descriptive title I searched for other feature requests and couldn't find a duplicate...

  • Improve documentation and error reporting for lack of networking in Pyodide and PyScript #633 [tiran] type: enhancement backlog

    Checklist I added a descriptive title I searched for other issues and couldn't find a duplication I already...

  • Third-party module import #627 [Minecodes] type: enhancement needs-triage backlog

    Checklist I added a descriptive title I searched for other feature requests and couldn't find a duplicate...

    Show Children

    • marimeireles: Also this one @madhur-tandon. Thanks!!!

  • scapy and mysql.connector python libraries do not work with pyscript #619 [Jonathan70852] needs-triage

    Checklist I added a descriptive title I searched for other issues and couldn't find a duplication I already...

  • Improving the test suite #601 [marimeireles] tag: tests epic

    What kind of tests do we want? End-to-end tests and Unit tests. We should start with unit tests and then end-to-end...

  • Every new feature should have a test #615 [marimeireles] tag: docs sprint

    The action here is to add it to the docs, somewhere in the CONTRIBUTING file and try to adopt it on the way we do...

  • Python script in <py-script> content may render before script execution #296 [timdream] type: bug duplicate waiting on reporter tag: styling

    Hi! Interesting project! I didn't try to set it up but looking at getting started it seems that a small browser...

    Show Children

    • marimeireles: I'm going to do it, but if anyone feel like this is different enough, please feel free to re-open it :)

    • JeffersGlass: I think it's good to leave closed, but I think it's more closely related to #810 - that issue is...

  • > character is being escaped to &gt; in py-repl #518 [rod2ik] type: bug needs-triage

    Checklist I added a descriptive title I searched for other issues and couldn't find a solution or duplication I...

    Show Children

    • marimeireles: Closed as fixed. I hope this is correctly handled? If not, please re-open! Thank you!

    • rod2ik: This issue is solved for me two, replacing alpha by the latest of course : <head> <link...

  • <py-config> should NOT go to <head> #820 [antocuni] good first issue help wanted tag: docs tag: example backlog

    Custom elements are not allowed in <head>. For example, if you run this in w3c validator it passes: <!DOCTYPE...

    Show Children

    • JeffersGlass: I wonder if this is a normative issue with the validator, or an actual violation of the spec. I...

  • The main page of the docs shows a warning #819 [antocuni] tag: docs backlog

    The home page of the docs show this: Warning Please note, this documentation is just a placeholder and should not...

  • Consider replacing SimpleHTTPServer with Playwright interceptor #693 [pauleveritt] needs-triage backlog

    Checklist I added a descriptive title I searched for other issues and couldn't find a duplication I already...

    Show Children

    • pauleveritt: Let's drop this. @tedpatrick covered it in #829

  • Use Playwright's wait_for_selector to delay until Pyodide loads and renders #694 [pauleveritt] type: enhancement tag: tests backlog

    Checklist I added a descriptive title I searched for other issues and couldn't find a duplication I already...

    Show Children

    • pauleveritt: Let's drop this also. I'll keep using it for collective stuff.

  • Creating new html elements using pyscript. #599 [TusharNautiyal-web] needs-triage backlog

    Checklist I added a descriptive title I searched for other issues and couldn't find a duplication I already...

  • PyScript should support rendering text #606 [fpliger] type: enhancement tag: styling tag: component backlog

    Checklist I added a descriptive title I searched for other feature requests and couldn't find a duplicate...

  • Saving the state of components (NOT EXECUTION) #608 [fpliger] type: enhancement tag: component backlog

    Checklist I added a descriptive title I searched for other feature requests and couldn't find a duplicate...

  • Investigate support for CPython 3.11 #610 [antocuni] type: enhancement tag: interpreter tag: pyodide lang: python backlog

    Checklist I added a descriptive title I searched for other feature requests and couldn't find a duplicate...

  • [Discussion] Examples and their use for pyscript.net, locally, and for testing #766 [pww217] tag: tooling tag: tests waiting on feedback backlog

    Checklist I added a descriptive title I searched for other issues and couldn't find a duplication I already...

  • Feature: Run pyodide in worker #808 [joemarshall] type: enhancement backlog

    Checklist I added a descriptive title I searched for other feature requests and couldn't find a duplicate...

    Show Children

    • joemarshall: Is that async as in javascript scripts? i.e. with that syntax, by default it downloads the...

    • joemarshall: I think for me, the biggy is what to do about the js object when pyscript is run in a worker. ...

    • JeffersGlass: @joemarshall I'd agree with you:, using the async as a keyword for a py-script tag is probably...

  • The WebGL example never finishes loading #678 [antocuni] type: bug lang: typescript backlog

    The WebGL example shows a very weird behavior, which was discovered by #676 . The relevant test in the PR is this: ...

    Show Children

    • tedpatrick: With the changes in script.evaluate() in #796, this is now resolved. I have removed the XFAIL...

  • New PyScript Maintainer: Paul Everitt #824 [tedpatrick]

    We are pleased to announce the addition of Paul Everitt as a PyScript Maintainer. Paul has been very influential...

    Show Children

    • antocuni: welcome to the team @pauleveritt ! And thanks for all your contributions so far! 🎉

    • tedpatrick: Paul, I truly enjoy our conversations and hope we can enable your vision on PyScript. Thank you....

    • marimeireles: Welcome! 😄

    • pzwang: Thank you, Paul! And welcome!

    • ntoll: Welcome @pauleveritt, looking forward to collaborating.

    • madhur-tandon: Welcome @pauleveritt :)

    • ayirpconda: Welcome @pauleveritt !!!

    • JeffersGlass: Excited to work with you @pauleveritt!

    • pauleveritt: Thanks all. I spent time this weekend gradually moving examples into the collective, thinking...

    • fpliger: Welcome @pauleveritt ! Really excited... and thank you for all the contributions!! 🎉 🎉

  • New PyScript Maintainer: Jeff Glass #825 [tedpatrick]

    We are pleased to announce the addition of Jeff Glass as a PyScript Maintainer. Jeff has been very active within the...

    Show Children

    • antocuni: welcome to the team @JeffersGlass! I look forward to work more with you 🎉

    • tedpatrick: Jeff, Thank you. Onward! 🚀

    • JeffersGlass: Thanks @tedpatrick, @antocuni et al! Looking forward to working more with everyone.

    • marimeireles: Yesss! Welcome @JeffersGlass!

    • pzwang: Congrats and welcome, Jeff!

    • ntoll: 👋 @JeffersGlass

    • madhur-tandon: Welcome @JeffersGlass :)

    • ayirpconda: Welcome @JeffersGlass !!!

    • fpliger: Welcome @JeffersGlass ! Really excited... and thank you for all the contributions!! 🎉 🎉

  • Correctly handle HTML entities inside <py-script> source code #735 [antocuni] backlog

    Follow up of this conversation: #684 (comment) This is best explained by a simple example: <script...

    Show Children

    • marimeireles: Adding a snippet of an example of things that don't work: def...

  • The <py> icon shown in the docs is not transparent #818 [antocuni] type: enhancement good first issue help wanted tag: docs backlog

    This is very minor, but it annoys me :) Screenshot of the docs using the default dark theme: Screenshot of the docs...

    Show Children

    • spaetz: Based on https://pyscript.net/assets/images/pyscript-sticker-black.svg, here is a .png version...

  • Add file list indexes to /unstable/, /latest/, and /release/** subdirectories of pyscript.net #551 [pww217] type: enhancement good first issue tag: tooling tag: styling tag: docs backlog

    Checklist I added a descriptive title I searched for other feature requests and couldn't find a duplicate...

  • [FEATURE] Multiple py-envs in a single html file #149 [nixjdm] type: enhancement ideas backlog

    Assuming it's possible, having multiple, different, simultaneously available py-envs could be very useful. As an...

    Show Children

    • nixjdm: Yes, precisely. Better IPC would be great, but the DOM would be sufficient for cross WASM...

  • [CHORE] Pin dependency version where possible #432 [pww217] type: enhancement good first issue tag: tooling tag: tests backlog

    Is your feature request related to a problem? Please describe. A clear and concise description of what the problem...

  • Add index-url option to py-config as external source for .whl files #842 [msachsenhauser] type: enhancement backlog

    Checklist added a descriptive title searched for other issues and couldn't find a solution or duplication ...

    Show Children

    • JeffersGlass: Interesting! Just so we understand better - it sounds like the issue is that corporate network...

    • msachsenhauser: Basically, we are not allowed to fetch packages directly from sources outside of the corporate...

  • Js import doc failure #771 [21Turtles] waiting on reporter

    Checklist I added a descriptive title I searched for other issues and couldn't find a solution or duplication I...

    Show Children

    • marimeireles: Closing this as no response was given. Feel free to re-open it with more info. Cheers.

  • Don't hide undefined elements in the CSS #810 [antocuni] good first issue help wanted tag: styling backlog

    Currently we have this CSS rule: pyscript/pyscriptjs/src/styles/pyscript_base.css ...

    Show Children

    • tedpatrick: The only PyScript element we need to hide is <py-config>, let's simply list the tags that need...

  • Incorrect time.sleep #324 [eoksum] type: bug tag: pyodide lang: python backlog

    Describe the bug Using time.sleep() is not giving the desired result. I tested it with time.sleep(20) and execution...

    Show Children

    • marimeireles: @antocuni the idea is that we tackle this, correct? Or are we're closing it as resolved?

    • antocuni: It's not resolved, so it should be kept open.

  • <py-button> and <py-inputbox> should be killed, or at least they should not execute code #854 [antocuni]

    This is a proposal which would be a big change in how you use <py-button> and <py-inputbox> but I think that the...

    Show Children

    • tedpatrick: Assuming our event implementation supported all event types... we can add custom lifecycle...

    • tedpatrick: I feel these components should not exist in PyScript. I view them as signals that the event API...

    • antocuni: I feel these components should not exist in PyScript. I feel the same but I was not bold enough...

    • tedpatrick: Pardon my bold tone. I simply want to align with the Web and enable any of these elements to...

    • pauleveritt: I wonder if there's room for some prototypes outside the current codebase. Kind of R&D...

    • tedpatrick: Yes I have had a few proposals and lacked an effective place to put them. I would also welcome...

    • tedpatrick: Added the https://github.com/pyscript/research Added WIP event research as a proposal here

    • antocuni: I wonder if there's room for some prototypes outside the current codebase. Kind of R&D...

  • Behaviour of py-*: how to pass event #835 [dj-fiorex] tag: docs backlog

    Checklist I added a descriptive title I searched for other issues and couldn't find a solution or duplication I...

    Show Children

    • JeffersGlass: This behavior was changed as part of #686, which was included in the 2022.09.1 release of...

    • dj-fiorex: ok thank you for the explanation! Maybe the best thing to do is to have some examples that...

    • tedpatrick: Yes, we need a way to get the event passed cleanly into the function. Looks like an area of work.

    • dj-fiorex: I'm ready to give some help in my free time, where can i look to get an overview of the event handler?

    • JeffersGlass: Thanks @dj-fiorex! That would be swell. The logic for the py-*event handling is in...

    • tedpatrick: I am working on this at 2 levels: How do we subscribe py-{event} at startup How do we support...

    • tedpatrick: You can also use a create_proxy <html> <head> <link rel="stylesheet"...

    • JeffersGlass: +1 to sometime having a solution that works when attributes are added after initialization -...

    • tedpatrick: That syntax is what several leading JS frameworks do today, it isn't standard but it is the...

    • marimeireles: Hey @dj-fiorex, my input for docs is that we may start introducing real content to the Reference...

    • tedpatrick: And now for something completely different... In exploring how to address the issues in py-event...

    • antocuni: i like love the py.* proxy for event ( i already use that in pygame-script), but i don't think...

    • pmp-p: According to Mozilla's docs window.event is deprecated, isn't it? Sure but the window.event on...

    • antocuni: Sure but the window.event on python side is empty, so it's safe to use it for what it was/is...

    • tedpatrick: Window.event is deprecated but it has very wide...

    • pmp-p: If so, I don't think it's not safe at all. Even on the Python side, js.window is a reference to...

    • antocuni: indeed it can have side effects and it's wasted cycle to send it back to js, why not just set...

    • JeffersGlass: @tedpatrick This is a very slick implementation! I agree with your four goals - the only thing...

    • dj-fiorex: Hello guys, i'm a web developer for 90% of my time and 10% python, and i can say that in the web...

    • pmp-p: i like love the py.* proxy for event ( i already use that in pygame-script) but i don't think...

    • pauleveritt: Small note...I agree with @antocuni about the event argument being deprecated. My IDE is yelling...

    • antocuni: Small note...I agree with @antocuni about the event argument being deprecated. My IDE is yelling...

    • pauleveritt: @antocuni Yes. I will generally wear the hat for "Good IDE and tooling integration" and this is...

  • No Python output if console.log() is called after Python code #712 [marimeireles] type: enhancement backlog

    Checklist I added a descriptive title I searched for other issues and couldn't find a solution or duplication I...

    Show Children

    • marimeireles: Fixed by #749

  • Should we really use Codespell? #855 [marimeireles] needs-triage

    Checklist I added a descriptive title I searched for other issues and couldn't find a duplication I already...

    Show Children

    • dopplershift: You probably want to look at the -x or --exclude-file option for codespell, which lets you list...

    • marimeireles: @dopplershift thanks for chiming in! Yeah, but that's my exact problem with it, I don't want to...

    • dopplershift: Right, so if you read the docs I linked to, the --exclude-file option doesn't exclude a specific...

    • marimeireles: Ahhhn, sorry for that! I didn't click the link. Thank you @dopplershift :-)

    • marimeireles: Okay that's cool. So I'm gonna close this one since this is fine =) Thank you for the patience...

  • Runtimes must be specified after packages and paths #859 [rjschave] tag: docs

    Checklist I added a descriptive title I searched for other issues and couldn't find a duplication I already...

    Show Children

    • JeffersGlass: I believe this is not so much a bug in PyScript but a behavior of TOML Tables. Table (and arrays...

    • rjschave: I could have been more clear - I didn't think this was a bug so much as unspecified/unexpected...

    • JeffersGlass: Thanks @rjschave! I didn't mean to sound critical - you're totally right that it's nonintuitive,...

    • tedpatrick: +1 for adding this to docs

    • tedpatrick: Need 1 approval here: #861

  • Print losing output context #230 [jim22k] type: bug backlog

    These work as expected: Calling print inside <py-script output="output-div"> will write to the output div, as...

    Show Children

    • marimeireles: This falls under the case of unspecified target that throws an exception in case you try to...

  • [BUG] sys.stdout.isatty raises AttributeError #280 [ptmcg] type: bug lang: python backlog

    Describe the bug When calling sys.stdout.isatty() within a PyScript block, we get the following message (running in...

    Show Children

    • marimeireles: Closing as fixed!

  • [622] py-script should always output to console #634 [fpliger] type: enhancement backlog

    Checklist I added a descriptive title I searched for other feature requests and couldn't find a duplicate...

    Show Children

    • marimeireles: Closing as fixed.

  • PyScript Community Call - October 18, 2022 11AM CST #836 [tedpatrick]

    On October 18, 2022, at 11 AM CST, the PyScript Core Team will host our 1st PyScript Community Call. PyScript...

    Show Children

    • marimeireles: We should also post it on: twitter anaconda nucleos discord channel :)

    • tedpatrick: Community Call Meeting Details: Date: October 18, 2022, at 11 AM CST (1 hour) URL:...

    • marimeireles: Created a post on the nucleos. 👍 Can you or someone post it on the discord? :)

    • marimeireles: Passcode: 785650

  • Printing in the same line isn't working #472 [DorkYBru] invalid backlog

    Checklist I added a descriptive title I searched for other issues and couldn't find a solution or duplication I...

    Show Children

    • marimeireles: This doesn't work and I have no idea why. Here are some interesting tests I've been...

    • JeffersGlass: I think thereason is we've overridden stdout to point to console.log(), and pyodide only calls...

    • marimeireles: So... I think this is an upstream bug? @antocuni opinions? Also thanks @JeffersGlass amazing ✨

    • antocuni: So... I think this is an upstream bug? well, it's not a bug, it's a limitation of the...

  • [622] py-script should only render to the page through the `display` function #635 [fpliger] type: enhancement needs-triage backlog

    Checklist I added a descriptive title I searched for other feature requests and couldn't find a duplicate...

    Show Children

    • antocuni: EDIT: this is wrong, nevermind 🤦‍♂️ @marimeireles you closed this as completed but it's not true...

    • antocuni: Sorry, I made a mistake and I was running pyscript on the wrong branch. I confirm that this...

  • Importing a new package that doesn't exist in `Pyodide` #85 [sudomaze] tag: pyodide

    I have been trying to look into ways to import torch but I couldn't manage to do so because it isn't in Pyodide's...

    Show Children

    • upupbo: Would you like to ask if it supports loading torch models now？

  • pre-commit CI is failing #834 [JeffersGlass] type: bug backlog

    Checklist I added a descriptive title I searched for other issues and couldn't find a solution or duplication I...

    Show Children

    • tedpatrick: ESLINT ==> Strict TypeScript ==> Not Strict This is the source of the ESLint warnings. In...

    • JeffersGlass: I think there must be something about how the pre-commit CI action works that I don't...

    • madhur-tandon: Is it possible to SSH into the runners to investigate? It could be done with circleCI, but I am...

    • tedpatrick: I do not think anything is wrong with CICD or ESLint, this is highlighting that we lack...

    • antocuni: For reference, I reported it upstream: pre-commit/pre-commit#2537 The author seems to think that...

  • Relevant message when wrong file (through a typo or otherwise) accessed through a webserver #876 [madhur-tandon]

    Details here: pyscript/pyscriptjs/src/utils.ts Line 67 in 0cfe20c ...

  • Expose pyodide instance used by PyScript #494 [jim22k] type: enhancement needs-triage

    Checklist I added a descriptive title I searched for other feature requests and couldn't find a duplicate...

  • Panel example is broken #867 [meshachjackson] type: bug backlog

    Checklist I added a descriptive title I searched for other issues and couldn't find a solution or duplication I...

    Show Children

    • marimeireles: This is due to PyScript not being equal to the main. This issue was fixed and will be release on...

    • meshachjackson: Thanks for the quick reply, @marimeireles Is there a known workaround in the meantime?

    • marimeireles: Hey @meshachjackson np, happy to help. Depends on what you're doing, if you're running it...

    • marimeireles: Closing because fixed and just waiting for next version release. workaround is posted above...

  • Some multi-line pyscripts fail when enabling Auto Minify for HTML on Cloudflare #611 [miron] type: bug waiting on reporter backlog

    Checklist I added a descriptive title I searched for other issues and couldn't find a solution or duplication I...

    Show Children

    • marimeireles: @miron could you please confirm Jeffer's assumptions? This seems very reasonable. Thanks.

  • ConsoleMessageCollection doesn't collect all console messages #795 [marimeireles] type: bug waiting on reporter backlog sprint

    Checklist I added a descriptive title I searched for other issues and couldn't find a solution or duplication I...

    Show Children

    • marimeireles: Thanks for the review. I'll check this later this week. :)

    • marimeireles: @antocuni just so we don't loose track of it (maybe you prefer a new issue?) Not all error logs...

    • antocuni: @marimeireles PR #874 should fix it

  • Why do you force the output and errors to be visible after you evaluate an expression? #758 [dylanjcastillo] type: enhancement backlog sprint

    Checklist I added a descriptive title I searched for other issues and couldn't find a duplication I already...

    Show Children

    • marimeireles: I can't reproduce your error anymore. But also your code in general. I think the API went...

  • Remove all remaining references to svelte #883 [antocuni] help wanted tag: tooling lang: typescript

    With PR #881 I removed the last usage of svelte stores. We can now kill the remaining references to svelte in the...

  • <py-button> needs reference docs #848 [kathatherine] tag: docs backlog

    Checklist I added a descriptive title I searched for other issues and couldn't find a duplication I already...

    Show Children

    • marimeireles: Hey @kathatherine About all these issues you opened do you need support from our side or do you...

    • kathatherine: Yes, some support would be great! Ted asked that these issues be created so we could have better...

    • tedpatrick: Closing this issue as has high odds of depreciation

  • <py-config> tag needs reference docs #847 [kathatherine] tag: docs backlog

    Checklist I added a descriptive title I searched for other issues and couldn't find a duplication I already...

  • <py-repl> needs reference docs #849 [kathatherine] tag: docs backlog

    Checklist I added a descriptive title I searched for other issues and couldn't find a duplication I already...

  • <py-script> tag needs reference docs #846 [kathatherine] tag: docs backlog

    Checklist I added a descriptive title I searched for other issues and couldn't find a duplication I already...

  • py-repl doesn't support loading code with a src attribute #892 [fpliger] type: enhancement needs-triage

    Checklist I added a descriptive title I searched for other feature requests and couldn't find a duplicate...

    Show Children

    • antocuni: This is one of those cases where a Plugin system could help. Imho, we should raise the...

    • antocuni: Also, semi-related: #895

    • fpliger: and that, by default, should go on the console. If there's a plugin that intercepts the error...

  • Js TypeError: Cannot read properties of undefined (reading 'setAttribute') #677 [antocuni] type: bug lang: typescript backlog

    This is a JS error which is triggered by examples/panel_stream.html: it's very likely that it's not a bug in the...

    Show Children

    • FabioRosado: This was fixed in #747 but github doesn't like when you fix two issues in one 😄 closing now

  • PyScript always produces a console warning #902 [lwcorp] type: bug

    Checklist I added a descriptive title I searched for other issues and couldn't find a solution or duplication I...

    Show Children

    • JeffersGlass: Thanks for the issue submission! This error is due to a bug in Pyodide 0.21.2 (the default...

    • antocuni: yes, it seems to be a "bug" of pyodide which has already been fixed, and there is not much that...

  • py-repl creating duplicate ids #864 [tedpatrick] type: bug backlog sprint

    Checklist I added a descriptive title I searched for other issues and couldn't find a solution or duplication I...

    Show Children

    • marimeireles: On it :)

    • antocuni: @marimeireles note that PR #881 changed the way IDs are generated, now we use py-internal-X,...

    • marimeireles: The bug isn't there. It was in the way we write elements, was hard to find because I didn't...

    • marimeireles: This was fixed by Antonio's PR actually, before I landed mine! Fixing a different bug, that also...

  • [Tracking issue] Improve usability and provide better diagnostics for common mistakes #904 [antocuni] umbrella

    Sometimes I see PyScript users asking for help because they encounter an unexpected error or because their intuition...

    Show Children

    • antocuni: @JeffersGlass I have a feeling that you probably have more anecdotes to add to this list :)

  • New PyScript Maintainer: Fabio Rosado #898 [tedpatrick]

    We are pleased to announce the addition of Fabio Rosado as a PyScript Maintainer. Fabio has been active within the...

    Show Children

    • tedpatrick: Welcome, Fabio!

    • ntoll: Welcome @FabioRosado 🎉

    • FabioRosado: Thank you everyone! Looking forward to keeping contributing to ALL the things! 😄

    • JeffersGlass: Welcome Fabio! 🥳

    • marimeireles: Yip yip!

    • antocuni: Welcome 🎉

    • madhur-tandon: Welcome Fabio 🎈

    • fpliger: Welcome @FabioRosado !!

    • marimeireles: Closing this one! Welcome again Fabio! :)

  • [User-friendliness] It's not clear that <py-config> does NOT contain python code #906 [antocuni] user-friendliness

    See the Tracking issue #904 for the context. Original discord question This user thought that the content of...

    Show Children

    • Cheukting: I feel indifferent to this one. The documentation clearly states that py-config uses TMOL by...

    • antocuni: I feel indifferent to this one. The documentation clearly states that py-config uses TMOL by...

  • [User-friendliness] Event handler without the `event` parameter #905 [antocuni] user-friendliness

    See the Tracking issue #904 for the context. Original question on discord The mistake it this: async def...

    Show Children

    • Cheukting: I like this suggestion. The original syntax is very JS-like (as it supposes to be) and for...

    • tedpatrick: +1 The @event decorator can also detect arguments support and optionally not pass the event.

  • Behavior of display() targets #769 [antocuni] backlog sprint

    Related issues/PRs: #622 #635, #749 After lot of discussion, I think we agreed about what we want, which is: <div...

    Show Children

    • marimeireles: I'm closing this issue as things were mostly resolved here and seems like we're moving away from...

  • Printing is susceptible to cross-site scripting vulnerabilities by default #373 [rayjolt] backlog

    Describe the bug PyScript writes stdout from Python to a div element using its innerHTML property. From base.ts: ...

  • [BUG] print() doesn't output HTML tags. #347 [volpoh] tag: docs backlog

    print() doesn't output HTML tags I was experimenting in Pyscript and I tried to print an HTML table, but it didn't...

  • Using pyrebase in pyscript #918 [AggrOnline] type: bug needs-triage

    Checklist I added a descriptive title I searched for other issues and couldn't find a solution or duplication I...

    Show Children

    • marimeireles: Hey @AggrOnline here's your issue: ValueError: Can't find a pure Python 3 wheel for...

  • Browser normalizes html tags inside <py-script> #857 [pbsds] type: bug

    Checklist I added a descriptive title I searched for other issues and couldn't find a solution or duplication I...

    Show Children

    • marimeireles: Hey @pbsds, thanks for opening the issue! We're aware of this kind of behavior and intend to...

    • tedpatrick: +1 on umbrella ticket The issue looks to be having legal html in an inner string and these...

    • tedpatrick: Within the py-script element, we do this this.code = htmlDecode(this.innerHTML); where...

    • antocuni: I think we are basically doomed here. I fear that we cannot have a general & robust solution if...

    • tedpatrick: Not doomed... someone pushed all code through a DOMParser...

    • tedpatrick: The PyScript custom element could extend HTMLPreElement. This element preserves all whitespace...

    • tedpatrick: Ok I think I see the problem... The browser parses everything and if it sees HTML elements that...

    • marimeireles: Personally I dislike the comment approach and am -1. I wonder though, it might be the best...

    • antocuni: I've been looking into how to use the script tag but really have no idea how to implement it. It...

    • marimeireles: Yes, but keep in mind that we already analzyed pros&cons in #329. I didn't know about that....

    • antocuni: True, but I meant using something like class PyScript extends HTMLScriptElement { here. Does...

    • marimeireles: I've been trying! 😅 It's an interesting issue but yeah it's a hard one. I'll keep trying later...

    • antocuni: uh, I might have found "something". I'm undecided whether it's a brilliant solution or a...

    • fpliger: What's the goal? From the inception of the project and the <py-script> tag we were expecting...

    • tedpatrick: The problem with using a Custom Element that subclasses HTMLScriptElement is that the browser...

    • antocuni: What's the goal? avoid making a confusing mess that we will never be able to fix because it...

    • tedpatrick: We can add attributes to py-script (async,worker,scope), but we cannot do that to the script...

    • antocuni: We can add attributes to py-script (async,worker,scope), but we cannot do that to the script...

  • [DOCS] Node Version Requirements in READMEs #448 [nmstoker] tag: docs backlog

    Describe the bug This README page under the pyscriptjs folder does not mention the version requirements for node,...

  • [Discussion] Where should the dev docs live? #907 [FabioRosado] tag: docs

    Checklist I added a descriptive title I searched for other issues and couldn't find a duplication I already...

    Show Children

    • antocuni: +1 for having development docs. For example I wanted to write down some docs about all the...

    • JeffersGlass: +1 for having it as a section of the main docs: it because much easier to keep them in sync with...

  • Add Loading of Structured Packages to Py-Config #519 [JeffersGlass] type: enhancement needs-triage

    Checklist I added a descriptive title I searched for other feature requests and couldn't find a duplicate...

    Show Children

    • marimeireles: @madhur-tandon I think this is not relevant anymore due to your pr?

    • JeffersGlass: I think it would be the same thing now, but for the paths specification in <py-config>? I can...

    • madhur-tandon: @JeffersGlass To begin with, I started with the example you showed i.e. ### emoji.py ### def...

    • JeffersGlass: Hi @madhur-tandon - both examples above work for me, with the minor correction in my original...

    • madhur-tandon: Would you confirm whether either method works for you with that adjustment? Yes, I already...

    • pauleveritt: FWIW, regarding importing packages, @ryanking13 had a Pyodide package he worked on:...

    • JeffersGlass: But sometimes, the issue can occur in both of them so it is non-deterministic really and is...

    • ryanking13: FWIW, regarding importing packages, @ryanking13 had a Pyodide package he worked on:...

    • antocuni: Sorry for chiming in so late, I didn't see this discussion before. So, my two cents on it. Yes,...

    • madhur-tandon: @antocuni I think it is a very good proposal and will proceed to implement it. But I want to ask...

    • madhur-tandon: @antocuni On a second thought and perhaps taking some ideas from what @ntoll suggests -- We...

    • JeffersGlass: We could simply have a list of dictionary / objects with each dict having key has what the path...

    • antocuni: re @madhur-tandon # for a local resource [[fetch]] path = "utils/random/generator.py" uri =...

    • JeffersGlass: If so, in which way this is simpler than my original proposal? Simpler in the very literal...

    • antocuni: Simpler in the very literal sense of: there are only two parameters to understand instead of...

    • madhur-tandon: @antocuni your understanding regarding both the cases below is correct: [[fetch]] path =...

    • antocuni: This is simpler in the sense that right now -- in your original proposal -- the user has to...

    • fpliger: As shocked as I am... I'll say I mostly agree with @antocuni here. :D I don't love the verbosity...

    • antocuni: I might have an idea which could solve in an easy and elegant way the majority of use cases...

    • fpliger: Really like that approach. Wow @antocuni , I really think you are starting to see things as I do 🤣 🤣 🤣 🤣

    • antocuni: I think there is one small tweak that we can discuss: according to what I proposed above, in the...

    • JeffersGlass: Very nice @antocuni ! I think this is really excellent. Per your last example in the single file...

    • fpliger: I'm aligned with @JeffersGlass on consistency here... And re: naming, if I understand right...

    • antocuni: Per your last example in the single file case - my two cents is that it's maybe more trouble...

    • fpliger: so you are proposing that to is always a folder? Works for me, but then how do you handle the...

  • Documentation contains references to py-env tag #921 [mdlattimore] good first issue tag: docs

    Checklist I added a descriptive title I searched for other issues and couldn't find a duplication I already...

    Show Children

    • antocuni: I think that @madhur-tandon did some work on those docs recently, so he probably knows whether...

    • mdlattimore: If it still needs work, I have made what I think are the appropriate corrections, if that helps.

    • madhur-tandon: Hi @mdlattimore It's currently being fixed in PR #914. These docs were written by an external...

    • madhur-tandon: Fixed in #914

  • [[Fetch]] from: should not escape '&' in URLs #925 [JeffersGlass] type: bug

    Checklist I added a descriptive title I searched for other issues and couldn't find a solution or duplication I...

    Show Children

    • antocuni: we probably need to call htmlDecode on it, as we do for <py-script>: ...

    • madhur-tandon: Thanks @antocuni, I have opened a PR fixing this. @JeffersGlass I have checked the fix from my...

    • JeffersGlass: Thanks for the swift PR all!

  • Generate config file that contains all the modules from the standard lib you need and load it. #941 [PunchCakee] type: enhancement needs-triage

    Checklist I added a descriptive title I searched for other feature requests and couldn't find a duplicate...

  • [PROPOSAL] Python Plugin System #891 [fpliger] type: enhancement tag: plugins

    Checklist I added a descriptive title I searched for other feature requests and couldn't find a duplicate...

    Show Children

    • antocuni: the current workflow is a mess and needs to be refactored I designed in my head a possible...

    • fpliger: Higher level API (Python) Was thinking we might support plugins via a few ways... loosely...

    • antocuni: Let me answer this first: I'm not too attached to terminology here but do think that component...

    • tedpatrick: "A Plugin is just a set of Python code that is loaded by the main pyscript logic and contains...

    • antocuni: "A Plugin is just a set of Python code that is loaded by the main pyscript logic and contains...

    • fpliger: So, we should just call them custom elements, and use decorators such as...

    • antocuni: Wow, lots of things we agree on, I'm not used to it 😂 Let me answer only to the last remaining...

    • fpliger: Yeah. I think it's a good starting point and nothing prevents us to add it soon after. +1 on...

    • antocuni: I AGREE 😂

    • fpliger: Ok... as I develop this I realize we didn't talk too much in details about the API for plugins...

    • antocuni: Ok... as I develop this I realize we didn't talk too much in details about the API for plugins...

  • Use a plugin system to refactor the life cycle of a PyScript page #763 [antocuni] backlog tag: plugins

    TL;DR: I'm proposing to model the life cycle of a PyScript page using a plugin system. The main logic is very slim,...

  • Deprecate <py-title> <py-inputbox> <py-button> <py-box> #897 [tedpatrick] backlog epic

    Within the next release, we plan to deprecate the following custom...

    Show Children

    • tedpatrick: Fixes #854

    • FabioRosado: As part of this effort we also should update all the examples to stop using these elements and...

    • tedpatrick: Deprecation Cycle Plan Remove all example use of deprecated items Add warnings to all elements...

    • tedpatrick: We need to write the Deprecation Cycle down somewhere in permanent ink.

    • antocuni: This might be a silly question, but I'm curious about the deprecation cycle, should we create a...

    • JeffersGlass: @antocuni there's always the venerable showError() - I would also love to see it become...

    • FabioRosado: I'll hack something to show an alert on the page, I'm thinking maybe an alert banner that can be...

    • JeffersGlass: +1 to dev docs idea!

    • antocuni: @antocuni there's always the venerable showError() - I would also love to see it become...

  • Add flag to send HTML or plain Text to banner #924 [FabioRosado] type: enhancement good first issue

    Checklist I added a descriptive title I searched for other issues and couldn't find a duplication I already...

  • Include build artifact in release automatically #851 [pww217] type: enhancement tag: tooling

    Checklist I added a descriptive title I searched for other feature requests and couldn't find a duplicate...

  • Add docs for Py-Terminal once its merged #923 [FabioRosado] tag: docs tag: plugins

    Checklist I added a descriptive title I searched for other issues and couldn't find a duplication I already...

  • <py-config> errors are failling silently inside pytest #853 [marimeireles] type: bug

    Checklist I added a descriptive title I searched for other issues and couldn't find a solution or duplication I...

    Show Children

    • antocuni: good catch! I have modified the title to be more descriptive, because this is a problem which is...

    • FabioRosado: I think we can close this issue now? The refactoring and tests that antonio created seem to...

    • antocuni: uhm, that's a good question. Currently you are only getting the error in the console but the...

  • pyscript fails to load on homeassistant >= 2022.8 #880 [DACN] type: bug waiting on reporter

    Checklist I added a descriptive title I searched for other issues and couldn't find a solution or duplication I...

    Show Children

    • JeffersGlass: I might be wrong here, but this sounds like an issue with homeassistant and not PyScript....

    • DACN: Agree that it looks similar to the issue you have highlighted. I can confirm that when I remove...

    • tedpatrick: Is this related to a failed import paths within <py-config> New docs are...

    • DACN: Update - more in hope than expectation, tried on latest release 2022.11. Still same issue....

    • JeffersGlass: @DACN - did you figure out what the issue was? Would be curious what the solution was, for the...

  • Error banner now shown if we fail to fetch path with a live server #934 [FabioRosado] needs-triage

    Checklist I added a descriptive title I searched for other issues and couldn't find a duplication I already...

    Show Children

    • antocuni: Nice finding! But now I also would like to understand why it works without --dev, it might...

    • FabioRosado: That's a good point! I wonder if the test is just a bit wrong? I'm assuming that maybe fetch...

    • antocuni: I just realized something. So: it #935 is correct because we need to correctly handle both 404...

    • FabioRosado: Agreed, there was this comment in the code: NOTE! If we raise an exception...

    • antocuni: I think in this specific case, if we get a FileNotFound error, we shouldn't call route.abort()...

  • PyScript 2022.09.01 has stronger opinions about InvalidVersions in Python wheels #916 [ross-spencer] type: bug invalid

    Checklist I added a descriptive title I searched for other issues and couldn't find a solution or duplication I...

    Show Children

    • prettybits: Is there guidance on what a valid version number is expected to be? At least since the micropip...

    • antocuni: I think that @prettybits nailed it: this is probably due to an upstream change in...

  • Improve PyScript Startup Sequence #164 [fpliger] type: enhancement tag: environment backlog

    The current startup sequence is janky and happens "with best hopes" relying on the timing of when things happen on...

    Show Children

    • antocuni: And please provide hooks/ events that I as a developer can use to convey information to users...

  • pyscript.net landing page does not lead to other useful content #872 [mwaskom] type: bug needs-triage

    Checklist I added a descriptive title I searched for other issues and couldn't find a solution or duplication I...

    Show Children

    • pauleveritt: It would also be nice to link to the Awesome PyScript page:...

    • FabioRosado: Perhaps we can close this issue, we have pyscript.net that links to the examples, documentation...

    • pauleveritt: Agreed, close it. Future work can be new tickets.

  • Add support for sending data to webhooks #919 [temal32] type: enhancement needs-triage

    Checklist I added a descriptive title I searched for other feature requests and couldn't find a duplicate...

    Show Children

    • cruncher12: Maybe check out the requests system already built into PyScript? It should allow the access you...

    • marimeireles: Exactly what @cruncher12 said :) Check our docs to learn how to deal with APIs...

  • PyScript should include version information #546 [fpliger] type: enhancement tag: tooling backlog

    Checklist I added a descriptive title I searched for other feature requests and couldn't find a duplicate...

    Show Children

    • marimeireles: @JeffersGlass no one is working on this. If you have the space, please go for it! ☺️

    • JeffersGlass: Working on it! The version-reporting part is done and fairly straightforward, the more...

  • Unable to use pyfetch with POST #962 [Mailstorm-ctrl]

    I can't seem to get pyfetch to work with a POST request where the API is expecting specific data. Almost all...

    Show Children

    • JeffersGlass: Hmmm curious! Can you copy/paste the network error you're getting? Are you running...

    • JeffersGlass: For what it's worth, in general POST pyfetch does work. Here's a brief example with the reqres...

    • Mailstorm-ctrl: Hmmm curious! Can you copy/paste the network error you're getting? Are you running...

  • get/set functions to get code from REPL #954 [cruncher12] type: enhancement backlog

    It's possible to fetch the code from a REPL tag as described by Jeff in the comment, but it'd be ideal to have an...

    Show Children

    • JeffersGlass: For pre-writing code into a REPL, you can populate the <py-repl> tag with text: <py-repl> def...

    • marimeireles: @cruncher12 does Jeff's reply answer your question? If yes, please feel free to close the issue. Cheers!

    • antocuni: well, I'm not sure it's a good idea closing this issue. Jeff's answer might work but it's...

    • marimeireles: If you think this makes sense to add in the API :) I'm pro.

  • kill the global `runtime` export in main.ts #942 [antocuni] backlog

    copy&paste of the original discussion from here: #868 (comment) I agree that we should have a way to interact with...

    Show Children

    • JeffersGlass: Just to move my two cents of the conversation in here from #868: All very good points @antocuni...

  • PyScript should support more than on py-repl per page #893 [fpliger] type: enhancement good first issue help wanted lang: typescript backlog

    Checklist I added a descriptive title I searched for other feature requests and couldn't find a duplicate...

    Show Children

    • antocuni: After merging #884, the code snippet about is outdated. The updated one is this: ...

    • fpliger: Thanks for pointing it out. I think the main issue is less about the labels and more about the...

    • antocuni: Thanks for pointing it out. I think the main issue is less about the labels and more about the...

  • [DISCUSSION] Behavior of <py-script src=...> #895 [antocuni] backlog

    The current behavior of <py-script src=...> is confusing and suboptimal IMHO. It is implemented in this way: ...

    Show Children

    • fpliger: @antocuni, good news.... we disagree! 🤣 Ok, with my serious face on, I do agree that the current...

    • antocuni: @antocuni, good news.... we disagree! 🎉 😂 Ok, with my serious face on, I do agree that the...

    • ntoll: This is a fascinating discussion. Thank you so far for such a thoughtful read. What follows is...

    • fpliger: Mmmm... @antocuni @ntoll I feel like we are all thinking about this at different levels and with...

    • ntoll: Ok, let's imagine the scenario where a user has a Scientific dashboard with different...

    • antocuni: I honestly don't think the core of the issue itself is related to src or to the <py-script> but...

    • JeffersGlass: @antocuni I should really set up an alert for the word 'namespace' in this Repo 😅 To be honest,...

    • JeffersGlass: Two Paths to the Same End I know this is well understood by this group and has already been...

    • fpliger: Thanks, @JeffersGlass for the thoughtful comment (as usual). I'm +1 on most of it so I'll...

    • antocuni: My firm belief here is that we won't fix the problem by creating an awkward API but rather by...

    • fpliger: the order of execution is not the core issue here. It's incidental and I had to mention it only...

    • JeffersGlass: You can have src if every tag has its own isolated scope. I think this should be the solution,...

    • antocuni: +1 on this. I think it's probably the only way we can converge. I'd also suggest that, if we all...

    • JeffersGlass: That's what I understand, we're proposing, yeah. To be clear, I would still like a way for tags...

    • antocuni: As I've said elsewhere, though, my use cases tend to be more "Using PyScript to talk about...

    • JeffersGlass: So, I don't know how far along you might be in implementing these ideas you are, and I don't...

  • Allow disabling splash screen #900 [lwcorp] type: enhancement backlog

    Checklist I added a descriptive title I searched for other feature requests and couldn't find a duplicate...

    Show Children

    • marimeireles: This makes sense to me. I believe making this optional shouldn't be terribly complicated,...

  • Allow to turn off debug mode #901 [lwcorp] type: enhancement backlog

    Checklist I added a descriptive title I searched for other feature requests and couldn't find a duplicate...

    Show Children

    • antocuni: While those messages are awesome for debugging, they're very bad for production. I'm not an...

    • lwcorp: So I guess I believe the default should be debugging_level = 'error' which is what JavaScript...

    • antocuni: So I guess I believe the default should be debugging_level = 'error' which is what JavaScript...

    • FabioRosado: +3 for adding an option for configuring log level It also feels like the default logging is a...

    • marimeireles: +2 for adding an option for configuring the log level plus I guess hackers might sometime be...

  • target_id is overwritten when id is specified by the user #932 [marimeireles] type: bug

    Checklist I added a descriptive title I searched for other issues and couldn't find a solution or duplication I...

    Show Children

    • antocuni: I think this is a duplicate of #878

    • JeffersGlass: You're right that (at least part of) the problem relates to awaiting the evaluation of the...

    • antocuni: So coroutines will need to use display(..., target=...). Which I can live with, and I think is...

    • marimeireles: I think it's a similar issue but here I'm advocating for how the use of user generated ids...

    • marimeireles: Not reproducible! Since #928

  • Wrong cursor style for <input> elements #966 [SpaceCowboy-71] type: bug needs-triage

    Checklist I added a descriptive title I searched for other issues and couldn't find a solution or duplication I...

    Show Children

    • SpaceCowboy-71: I added a PR which would fix this issue, see here.

  • Unable to set different runtime if direct downloading it #969 [FabioRosado] type: bug needs-triage

    Checklist I added a descriptive title I searched for other issues and couldn't find a solution or duplication I...

  • Android WebView support #943 [LoreBadTime] type: enhancement

    Checklist I added a descriptive title I searched for other feature requests and couldn't find a duplicate...

    Show Children

    • JeffersGlass: What version of PyScript are you using? /latest, /unstable, /releases/{version_number}?? The...

    • LoreBadTime: After a little testing PyScript on Android WebView works like charm, with enough string...

    • antocuni: if pyscrpt doesn't load fast enough that variable it's undefined, the only workaround working...

    • JeffersGlass: How much cash changed hands to make this happen? 😛 Seriously though, you're totally right -...

    • LoreBadTime: hi there, i successfully made a native android app working along with pyscript...

  • Repl Output is replaced even if it shouldn't (i.e. loops) #975 [limitcracker] type: bug needs-triage

    Checklist I added a descriptive title I searched for other issues and couldn't find a solution or duplication I...

    Show Children

    • limitcracker: is there an option for the repl tag in order to not reload like it did in the alpha version?

    • marimeireles: Yep! Good catch, I'm looking into it. Thanks @limitcracker :) Also if you want to dive into...

  • Provide ability to configure HTML escaping of rendered output #182 [philippjfr] tag: rendering backlog

    As first laid out in #121 we are facing an issue with what to do with output that contains HTML characters. To quote...

    Show Children

    • JeffersGlass: This issue predates the current display() syntax by quite a ways, but still, I believe the...

  • Proposal for better Output and Rendering Design #622 [fpliger] type: enhancement epic

    Checklist I added a descriptive title I searched for other feature requests and couldn't find a duplicate...

    Show Children

    • marimeireles: Relevant to the discussion as in we should keep in...

  • [FEATURE] How to display list elements in HTML tags using for loop? #315 [lakhdar-blk] duplicate

    ls = ['name1', 'name2', 'name3'] for name in ls : " how to display for example all names...

    Show Children

    • JeffersGlass: The API has progressed quite a bit since this original issue; to cover the original need, in the...

  • Add documentation on how to run PyScrip offline and the limitations of it #581 [marimeireles] tag: docs backlog

    Show Children

    • pauleveritt: In the PyScript Collective app, I have a little console script that automates the downloading. I...

    • Eliav2: @laynr thank you very much for this woking example! could you explain how did you understand...

  • Shift+Enter in py-repl inserts a newline #984 [antocuni] good first issue tag: repl lang: typescript

    if you press Shift+Enter in a py-repl, it does two things: execute the code (as expected) insert a newline (this is...

    Show Children

    • antocuni: For reference, this is the code which setups the keybindings: ...

    • FabioRosado: Thanks for this! I was wondering if my keyboard was acting up when it was just inserting a new line haha

  • display() sends the output to the wrong tag #878 [antocuni]

    <rant> During the infinite discussion in #769 we decided to use a "dynamic" implicit target for display(), which as...

    Show Children

    • JeffersGlass: I can speak a bit to the use of how we could use a ContextVar to help solve some of these issues...

    • antocuni: I don't think we can reliably use ContextVar. See #879 (comment) for more details.

    • marimeireles: Can't reproduce any of these problems anymore. I think we can safely close this one :)

    • antocuni: Can't reproduce any of these problems anymore. I think we can safely close this one :) Sorry,...

    • marimeireles: I thought we were already doing that. But alright, lemme check this ;)

  • Add error code to exceptions raised by PyScript #956 [FabioRosado] type: enhancement backlog

    Checklist I added a descriptive title I searched for other issues and couldn't find a duplication I already...

    Show Children

    • madhur-tandon: This sounds like a really good idea!

    • antocuni: yes, this is exactly what I had in mind. I wonder what is the best type for...

    • FabioRosado: This may be a terrible idea, but we could allow numbers as errorCode and then use switch...

    • antocuni: This may be a terrible idea, but we could allow numbers as errorCode and then use switch...

    • FabioRosado: This may be a terrible idea, but we could allow numbers as errorCode and then use switch...

    • FabioRosado: After thinking a bit more about this I'm +1 on the Enums idea, after searching online it seems...

  • Getting Started example uses deprecated pyscript.write() method. #973 [jasonwashburn] type: bug tag: docs

    Checklist I added a descriptive title I searched for other issues and couldn't find a solution or duplication I...

    Show Children

    • FabioRosado: Thank you for raising this issue to us! Would you be interested in opening a PR to fix this?

    • jasonwashburn: Thank you for raising this issue to us! Would you be interested in opening a PR to fix...

    • JeffersGlass: I think the intent of the is still clear either way. For what it's worth, the <py-script...

    • jasonwashburn: I think the intent of the is still clear either way. For what it's worth, the <py-script...

    • antocuni: btw, we should detect the output attribute of <py-script> tags and show a deprecation warning in...

    • madhur-tandon: Since #974 is merged, I guess we can close this right?

  • Push different pyscript versions of examples #987 [FabioRosado]

    Basically, I don't care too much about the exact naming, but I care a lot about being consistent between all the...

  • Docs are being released on push to main #937 [FabioRosado] tag: docs backlog

    Checklist I added a descriptive title I searched for other issues and couldn't find a duplication I already...

    Show Children

    • antocuni: Another thing which is semi-related to this is that all code examples in the doc should never...

    • FabioRosado: Okay I dug a bit more into this and I see what is happening, we have two GitHub actions: One to...

    • jezdez: There is also a third release workflow that is creating the docs per PR. At the time we...

    • JeffersGlass: Thanks @jezdez - for what it's worth Fabio, I believe this usage of /latest/ corresponds more to...

    • antocuni: yes, I think that the current naming scheme is confusing. +1 to renaming...

    • jezdez: I don't have any investment in the naming scheme, the docs infra was after all a hackday project...

    • antocuni: I don't have any investment in the naming scheme, the docs infra was after all a hackday...

    • JeffersGlass: The original purpose of this issue has been solved by #977 - any merge that touches /docs causes...

    • FabioRosado: Opened up the above issue to track the examples case, closing this issue now 😄

  • Add Plugin Lifecycle Hooks before/after each <py-script> tag executes #944 [JeffersGlass] type: enhancement backlog tag: plugins

    From a discussion on the Discord - for the purposes of enabling functionality around each PyScript tag, it would be...

  • Investigate Dask Integration #609 [madhur-tandon] type: enhancement needs-triage backlog tag: data

    Checklist I added a descriptive title I searched for other feature requests and couldn't find a duplicate...

    Show Children

    • FabioRosado: Here are some thoughts about supporting Dask after our chat in Slack yesterday. Providing that...

    • marcosmoyano: @FabioRosado I have no idea. Check the test results on the last distributed build and see if the...

  • When following the example to import local modules the error "ModuleNotFoundError: No module named 'data'" happens #1001 [douglasdcm] type: bug needs-triage

    Checklist I added a descriptive title I searched for other issues and couldn't find a solution or duplication I...

    Show Children

    • madhur-tandon: Paths to load: [] is empty as seen here, did you declare the py-config as described in the...

    • douglasdcm: Hi, @madhur-tandon thank you for the quick reply. I'll past here the html and data...

    • madhur-tandon: Aah, the script is https://pyscript.net/latest/pyscript.js while the [[fetch]] tag should be...

    • douglasdcm: I changed the latest to unstable and the message bellow appered The 'output' attribute is...

    • douglasdcm: I'll do this suggested change display(myElement, target="divID") and try again

    • madhur-tandon: Tagging @marimeireles and @FabioRosado here for help with display / output stuff.

    • FabioRosado: Hi @douglasdcm 👋 It seems we may need to improve the message in the banner 😄 You should be able...

    • douglasdcm: Hi, @FabioRosado thank you! I may doing something wrong. I added the display at the end of the...

    • FabioRosado: Apologies I was on my phone and didn't see the code properly. Your graph variable is called fig...

    • douglasdcm: Thank you @FabioRosado ! Now it is working fine. The Scatter plot has been shown correctly...

    • madhur-tandon: Yes, we can close this. Thanks @douglasdcm. The issues that you face are basically because the...

  • PyodideRuntime.run should not `await` #879 [antocuni]

    I noticed this while looking at the source code. Runtime.run is marked async: ...

    Show Children

    • JeffersGlass: @antocuni I would agree with you on either doing return or return void in pyodide.ts there. I...

    • antocuni: I am also on the boat of not really understanding what's going on with our async usage in the...

    • antocuni: Semi-related, I'm still not sure that it's a good idea to allow top-level async in our py-script...

    • JeffersGlass: I think it would be saner to completely remove all support for running async python code I'm...

    • antocuni: I think these are both related, and I agree with them both. If we make one change (and probably...

    • woxtu: FYI, just return and return await are almost the same, so the example works in parallel. A...

    • antocuni: FYI, just return and return await are almost the same, so the example works in parallel. uhm, I...

    • woxtu: The main difference is error handling. The following article may be...

    • JeffersGlass: I'm not even sure that the your two examples are exactly the same: does pyodide automatically...

    • antocuni: wow, THANK YOU a lot @JeffersGlass this was a heroic effort! I also tried to dive in the code...

    • JeffersGlass: @antocuni Thanks right back at you this! And for your keen eyes in finding these edges where...

    • antocuni: There are various approaches, but my philosophy is the following: since it's an advanced feature...

    • antocuni: If we do want to show a deprecation warning while using runPythonAsync() for one more version,...

    • JeffersGlass: we use pyodide.runPython everywhere (no more runPythonAsync). no special syntax: if you want to...

    • marimeireles: I know it's a very long discussion, but I'm honestly curious to hear @fpliger thoughts on...

    • fpliger: Wow... the time catching up on issues this week has confirmed a lot of my FOMO in the past weeks...

    • antocuni: That's, imho, the real solution. That being default is/was also my preference but iirc @ntoll...

    • hoodmane: As you can see by looking at the code, it seems that contextvars does not always survive a...

  • cannot Deploy py-script Web App on Github Pages #1003 [RizmyAbdulla] type: bug needs-triage

    Checklist I added a descriptive title I searched for other issues and couldn't find a solution or duplication I...

    Show Children

    • JeffersGlass: Hi @RizmyAbdulla ! I see you’ve closed this issue - were there any settings or adjustments or...

    • RizmyAbdulla: @JeffersGlass i tested my py-script web app on Brave and edge and it didn't work, but when I...

  • Support for raspberypi #1012 [marimeireles] backlog

    Checklist I added a descriptive title I searched for other issues and couldn't find a duplication I already...

  • Add Plugin Lifecycle Hooks/Events Before and After Each Py-Repl Evaluation #988 [JeffersGlass] type: enhancement tag: repl

    A user in the discord recently have asked if it's possible to do the following: <py-repl> print("Hello,...

    Show Children

    • antocuni: This reminds me of the recent post made on discord by @mchilvers:...

  • Intermittent Failure to Load Plugin Files #989 [JeffersGlass]

    An intermittent fatal issue is popping up when trying to load plugin files using the machinery in #961 . It feels...

    Show Children

    • FabioRosado: Still haven't figured what's happening, but it seems that the tests pass is the...

    • antocuni: Leaving this comment for posterity: it seems very likely that the root cause was this...

  • Add documentation for the splashscreen #1004 [FabioRosado] tag: docs

    Checklist I added a descriptive title I searched for other issues and couldn't find a duplication I already...

    Show Children

    • antocuni: @antocuni any concerns about documenting the .log method? +1 for documenting it

  • We should detect and throw an error if two scripts pointing to pyscript.js are found #1010 [FabioRosado] needs-triage

    Checklist I added a descriptive title I searched for other issues and couldn't find a duplication I already...

    Show Children

    • madhur-tandon: +1 to this issue

  • can you link external .py files? #532 [Ethan-Joven] needs-triage

    Checklist I added a descriptive title I searched for other issues and couldn't find a duplication I already...

  • [IUser-friendliness] Provide Context/Help around Unusable Pacakges #911 [JeffersGlass] user-friendliness

    See the Tracking issue #904 for the context. Currently, if a user provides a package name to <py-config> that either...

    Show Children

    • Cheukting: I agree, it takes some experience to know how long the wheel should be spinning and when...

  • Add Docs for `PyScript.Element` #979 [JeffersGlass] tag: docs backlog

    We make significant use of the Element class without API documentation - once #972 is merged, we'll have a nice...

  • We have two tests numbered as 03 #995 [marimeireles] type: bug

    Checklist I added a descriptive title I searched for other issues and couldn't find a solution or duplication I...

    Show Children

    • madhur-tandon: Tagging @antocuni here

    • antocuni: yes, I think that the proper question which we want to answer is "which test files we want to...

    • marimeireles: While we are at it, also rename test_02_output.py into test_02_display.py, because this is what...

    • antocuni: well, not really. aync is not used by any other test, and test_style is basically testing some...

    • madhur-tandon: Assigning myself

    • marimeireles: Yeah, I know they do. Alright, I have no strong feelings about it. +1ing Antonio here.

  • pyscript module not available #993 [pmerienne] tag: docs

    Checklist I added a descriptive title I searched for other issues and couldn't find a solution or duplication I...

    Show Children

    • pmerienne: In another documentation page...

    • JeffersGlass: Hi @pmerienne - there are two things going on here. First, until quite recently, we had been...

    • pmerienne: Hi @JeffersGlass , Thank you for your quick answer, I will wait for the next release for this...

    • JeffersGlass: If you want to play with the new features in development, you can source the bleeding-edge build...

    • pmerienne: Again, thank you @JeffersGlass that exactly what I needed ! Have a nice day and best wishes for...

    • madhur-tandon: Should we close this @JeffersGlass ?

    • JeffersGlass: Yes let's!

  • Pillow images are not rendered correctly #1015 [abdullahkhalids] type: bug

    Checklist I added a descriptive title I searched for other issues and couldn't find a solution or duplication I...

    Show Children

    • marimeireles: Hey @abdullahkhalids, thanks for opening the issue! Can you please try to render the image using...

    • abdullahkhalids: display(img) yields the same issue. There are no errors on console. The problem is with the...

    • FabioRosado: @abdullahkhalids Thank you for creating this issue. We have just merged a fix for this and will...

  • [RELEASE BLOCKER] Clean up the `PyScript` vs `pyscript` mess #986 [antocuni]

    There is a lot of confusion about using pyscript.XXX vs PyScript.XXX. Related PR #982 . Let's start from the current...

    Show Children

    • ntoll: @antocuni blimey. Thoughts (that mostly resonate with your proposed changes). Why are we using...

    • antocuni: Why are we using static methods (do we do something special with the class)..? Otherwise, they...

    • ntoll: in which way this is related to this issue? thinking My misunderstanding, and I must be getting...

    • JeffersGlass: Just to clear something up - what @FabioRosado and I are discussing in #982 is unrelated to...

    • JeffersGlass: On reflection, maybe I'm being too precious about the state of the API - especially with...

    • antocuni: With the DeprecatedGlobal approach which I described above, we can easily add as many names as...

    • JeffersGlass: Not sure if it's a good idea to use it for all the names which you mentioned, but if we want we...

    • fpliger: I'm +1 on all the proposal, except of 4. I'm quite committed to trying to give a deprecation...

    • fpliger: Also, there's another aspect of this that I want to make explicit (and that @antocuni and I...

    • antocuni: I'm +1 on all the proposal, except of 4. I'm quite committed to trying to give a deprecation...

  • Antigravity example is broken after stdout/display changes #1005 [fpliger] type: bug

    Checklist I added a descriptive title I searched for other issues and couldn't find a solution or duplication I...

    Show Children

    • antocuni: **NOTE: ** goes without saying that we should add a test as well :) what is not tested is broken ;)

  • <py-config> reference improvements #1006 [fpliger] type: bug type: enhancement tag: docs user-friendliness

    Checklist I added a descriptive title I searched for other issues and couldn't find a solution or duplication I...

    Show Children

    • FabioRosado: Agreed! I tried to break the wall of text a bit in this PR #982 Also added tutorials...

    • madhur-tandon: It mentions The <py-config> element should be placed within the <body> element. but I don't...

    • madhur-tandon: Assigning myself

    • antocuni: It was initially inside <head> but was later moved to <body>. Relevant issue: #820 Relevant PR:...

    • JeffersGlass: Adding on to antonio, the result of including a custom element in a tag seems to be that the...

    • fpliger: Wait, I'm not sure I understand..... <py-config> is not a Custom Element. What am I missing?

    • JeffersGlass: @fpliger Apologies, I got sloppy with my terminology. I should say any "non-typical" tags for......

    • JeffersGlass: Digging a little deeper, I believe this behavior is captured by HTML Spec Section 13.2.6.4.4 -...

  • Add fetch documentation #1007 [fpliger] type: enhancement tag: docs

    Checklist I added a descriptive title I searched for other issues and couldn't find a duplication I already...

    Show Children

    • madhur-tandon: Assigning myself

  • Test d3 is flaky due to Module Not Found d3 #759 [FabioRosado] type: bug tag: example backlog

    Checklist I added a descriptive title I searched for other issues and couldn't find a duplication I already...

    Show Children

    • antocuni: I'm reopening this issue because it seems that the test is flaky again. I will commit the...

    • chrisamow: I'm reopening this issue because it seems that the test is flaky again. I will commit the...

    • antocuni: @chrisamow thank you for reopening the issue, it was closed by mistake (I guess it was closed...

    • tedpatrick: Fixed in #1025

  • I Want Bleak Library to Work Integrated with Pyscirpt #1027 [omerkars78] type: enhancement needs-triage

    Checklist I added a descriptive title I searched for other feature requests and couldn't find a duplicate...

    Show Children

    • FabioRosado: Pyscript doesn't maintain specific packages, this is work done by pyodide, you may want to read...

    • omerkars78: Thank you very much! I will try! Fábio Rosado ***@***.***>, 7 Ara 2022 Çar, 17:25...

  • Freedom Units example is broken #1009 [chrisamow] type: bug needs-triage

    Checklist I added a descriptive title I searched for other issues and couldn't find a solution or duplication I...

  • Release Testing 2022.12.1.RC1 #1031 [tedpatrick]

    We are feature complete for a release of PyScript this week. We need your help testing 2022.12.1. How to test...

  • Pyscript and Element().write are not available inside child python scripts imported via py-env #525 [pandian912] type: bug needs-triage

    Checklist I added a descriptive title I searched for other issues and couldn't find a solution or duplication I...

    Show Children

    • marimeireles: @madhur-tandon could you please check this one too?

    • JeffersGlass: Since pyscript.py has been moved to a module as of #961, it is now possible to use import...

  • matplotlib.pyplot plots are not displayed #983 [cynthias13w] type: bug needs-triage

    Checklist I added a descriptive title I searched for other issues and couldn't find a solution or duplication I...

    Show Children

    • FabioRosado: Hello 👋 Perhaps @antocuni can chime in, but looking at the matplot docs under the scatter...

    • antocuni: Uhm, this is weird. Yesterday during the workshop we tried the same code inside jupyter and it...

    • cynthias13w: Hello, thank you both for your answers. @antocuni Yes, I remember the exact code. Here it is. 🙂

    • cynthias13w: Here are my observations. Using PyScript Using Jupyter notebook

    • antocuni: thank you @cynthias13w this is very useful. Also, what I can see it's very weird. Basically,...

    • madhur-tandon: @antocuni and @cynthias13w Have you guys tried to use plt.show() after plt.scatter(...)

    • madhur-tandon: Using plt.show() will make it work with jupyterlite as well. But we need to fix it for pyscript,...

    • madhur-tandon: Hi @cynthias13w I have investigated a bit and it turns out no patch is required. You are...

    • madhur-tandon: Closing since verified by @tedpatrick

    • tedpatrick: I am seeing good results on unstable build with the code @madhur-tandon proposed.

    • antocuni: I don't fully understand why you closed the issue. You don't need to call display() from...

    • madhur-tandon: @antocuni Let me give you some context. matplotlib backends are responsible for rendering the...

  • [PROPOSAL] Higher level Pythonic DOM interface #1034 [fpliger] type: enhancement ideas lang: python

    Checklist I added a descriptive title I searched for other feature requests and couldn't find a duplicate...

  • Dev instructions and docs are incomplete and all over the place #1033 [fpliger] good first issue tag: docs ideas

    Checklist I added a descriptive title I searched for other issues and couldn't find a duplication I already...

    Show Children

    • FabioRosado: This sounds good! Making it easier to find info is always good 😄

    • IanoNjuguna: @FabioRosado && @fpliger I'd really appreciate to be assigned this issue.

    • madhur-tandon: I'd really appreciate to be assigned this issue. Go ahead @IanoNjuguna :D

  • Remove Fetching `pyscript.py` from Tutorials #1035 [JeffersGlass] good first issue tag: docs

    Since #961 was merged, it is no longer necessary to [[fetch]] pyscript.py, like in this tutorial, as pyscript.py can...

    Show Children

    • madhur-tandon: Taking this up, thanks @JeffersGlass for noticing

  • Examples code is great but hard to actually read the html files themselves #1039 [fpliger] type: enhancement needs-triage

    Checklist I added a descriptive title I searched for other feature requests and couldn't find a duplicate...

  • PyScript.getPySrc only works once #1038 [fpliger] type: bug

    Checklist I added a descriptive title I searched for other issues and couldn't find a solution or duplication I...

  Releases

  Earliest to Most-Recent